Differential D23671

Don't check the auth algorithm for GCM.
ClosedPublic
Actions

Authored by jhb on Feb 13 2020, 8:37 PM.

Tags

None

Referenced Files

	F154673167: D23671.id.diff
	Wed, Apr 29, 5:00 AM

	Unknown Object (File)
	Tue, Apr 28, 3:41 AM

	Unknown Object (File)
	Tue, Apr 28, 12:56 AM

	Unknown Object (File)
	Tue, Apr 21, 11:03 AM

	Unknown Object (File)
	Mon, Apr 20, 4:32 AM

	Unknown Object (File)
	Sun, Apr 19, 1:46 PM

	Unknown Object (File)
	Sat, Apr 11, 8:47 AM

	Unknown Object (File)
	Thu, Apr 9, 7:25 PM

Subscribers

Details

Reviewers

• hselasky
kib

Commits

rS357891: Don't check the auth algorithm for GCM.

Summary

The upstream OpenSSL changes only set the cipher for GCM since the
authentication is redundant, and changes to OCF will soon remove
the GCM authentication algorithm constants entirely for the same
reason. In addition, ktls_create_session() already validates these
fields and wouldn't pass down an invalid auth_algorithm value to
any drivers or ktls backends.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Feb 13 2020, 8:37 PM

Herald added a subscriber: ae. · View Herald TranscriptFeb 13 2020, 8:37 PM

Harbormaster completed remote builds in B29361: Diff 68276.Feb 13 2020, 8:37 PM

• hselasky accepted this revision.Feb 13 2020, 8:42 PM

This revision is now accepted and ready to land.Feb 13 2020, 8:42 PM

Closed by commit rS357891: Don't check the auth algorithm for GCM. (authored by jhb). · Explain WhyFeb 13 2020, 11:04 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS357891: Don't check the auth algorithm for GCM..

Herald added a subscriber: imp. · View Herald TranscriptFeb 13 2020, 11:04 PM

pfg mentioned this in D17115: Generate /etc/services from the IANA registry (plus local mods).Feb 16 2020, 11:09 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

mlx5/

mlx5_en/

mlx5_en_hw_tls.c

8 lines

Diff 68289

head/sys/dev/mlx5/mlx5_en/mlx5_en_hw_tls.c

Loading...