Page MenuHomeFreeBSD

More sparc64 removal bits
Needs ReviewPublic

Authored by imp on Thu, Feb 13, 12:12 AM.

Details

Reviewers
dim
Summary

Remove sparc64 specific buid-system hacks

Remove all the sparc64 hacks and tweaks to the build system. We don't
need them anymore.

Remove sparc64 specific parts of rtld-elf.

Remove sparc64 specific parts of libm and fix comments

Once upon a time, sparc64 was the only ld128 architecture. However,
both aarch64 and riscv are now such architectures. Many of the
comments about how slow multiplication was on old sparc64 processors
are now no longer true. However, since no evaluation has been done for
aarch64 yet, it's unclear if they are still relevant or not. If not,
the code should be changed. If so, the comments should remove the
uncertainty.

Remove sparc64 specific parts of libc.

Also update comments for which architectures use 128 bit long doubles,
as appropriate.

The softfloat specialization routines weren't updated since they
appear to be from an upstream source which we may want to update in
the future to get a more favorable license.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 29334
Build 27235: arc lint + arc unit

Event Timeline

imp created this revision.Thu, Feb 13, 12:12 AM
emaste added inline comments.Thu, Feb 13, 4:54 PM
lib/msun/ld128/k_expl.h
268

maybe "was very slow"?
of course it probably still is slow on sparc64 but not relevant to FreeBSD

lib/msun/ld128/s_expl.c
97

s/beem/been/

share/mk/src.opts.mk
474

OK. We can probably drop this altogether, I'll take a look at that later.

emaste added a reviewer: dim.Fri, Feb 14, 11:56 PM

Overall LGTM with a few trivial nits

lib/msun/ld128/s_logl.c
539

s/are/were/ perhaps?

share/mk/bsd.cpu.mk
331–339

pedantic point but commit this separately first?