Page MenuHomeFreeBSD

More sparc64 removal bits
ClosedPublic

Authored by imp on Feb 13 2020, 12:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 4:47 AM
Unknown Object (File)
Dec 3 2023, 12:51 PM
Unknown Object (File)
Dec 3 2023, 12:51 PM
Unknown Object (File)
Dec 3 2023, 12:50 PM
Unknown Object (File)
Dec 3 2023, 12:33 PM
Unknown Object (File)
Nov 23 2023, 3:53 PM
Unknown Object (File)
Nov 8 2023, 11:07 PM
Unknown Object (File)
Oct 13 2023, 2:53 PM

Details

Summary

Remove sparc64 specific buid-system hacks

Remove all the sparc64 hacks and tweaks to the build system. We don't
need them anymore.

Remove sparc64 specific parts of rtld-elf.

Remove sparc64 specific parts of libm and fix comments

Once upon a time, sparc64 was the only ld128 architecture. However,
both aarch64 and riscv are now such architectures. Many of the
comments about how slow multiplication was on old sparc64 processors
are now no longer true. However, since no evaluation has been done for
aarch64 yet, it's unclear if they are still relevant or not. If not,
the code should be changed. If so, the comments should remove the
uncertainty.

Remove sparc64 specific parts of libc.

Also update comments for which architectures use 128 bit long doubles,
as appropriate.

The softfloat specialization routines weren't updated since they
appear to be from an upstream source which we may want to update in
the future to get a more favorable license.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lib/msun/ld128/k_expl.h
268 ↗(On Diff #68230)

maybe "was very slow"?
of course it probably still is slow on sparc64 but not relevant to FreeBSD

lib/msun/ld128/s_expl.c
97 ↗(On Diff #68230)

s/beem/been/

share/mk/src.opts.mk
474 ↗(On Diff #68230)

OK. We can probably drop this altogether, I'll take a look at that later.

Overall LGTM with a few trivial nits

lib/msun/ld128/s_logl.c
539 ↗(On Diff #68230)

s/are/were/ perhaps?

share/mk/bsd.cpu.mk
331–339 ↗(On Diff #68230)

pedantic point but commit this separately first?

This revision was not accepted when it landed; it landed in state Needs Review.Feb 26 2020, 6:55 PM
This revision was automatically updated to reflect the committed changes.