Page MenuHomeFreeBSD

ECN incorrectly set
ClosedPublic

Authored by rrs on Feb 12 2020, 12:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 8:46 PM
Unknown Object (File)
Nov 5 2024, 1:42 PM
Unknown Object (File)
Oct 14 2024, 7:09 AM
Unknown Object (File)
Oct 7 2024, 6:52 AM
Unknown Object (File)
Oct 1 2024, 7:41 AM
Unknown Object (File)
Sep 25 2024, 2:35 PM
Unknown Object (File)
Sep 23 2024, 9:32 PM
Unknown Object (File)
Sep 21 2024, 1:34 PM
Subscribers

Details

Summary

ECN requires that on the SYN both the CWR and ECT bits be set in order
for it to be considered a "request" for ECN. We therefore did not
correctly check for this condition. This fix should make it so we
enforce the RFC properly.

Test Plan

We can use pkt-drill to send in a SYN and make sure that it only
responds to the correct "ECN condtion" i.e. both bits set.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This revision is now accepted and ready to land.Feb 12 2020, 12:47 PM
This revision was automatically updated to reflect the committed changes.

Good catch!

I should have found that in D23230, when extending the meaning of V_tcp_do_ecn (for ECN+ and ECN++).

Please have a look into D23373 (simultaneous opens) also.