Page MenuHomeFreeBSD
Differential D23474

Limit memory usage in xz(1).
ClosedPublic
Actions

Authored by delphij on Feb 3 2020, 1:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 10 2024, 7:10 PM
Unknown Object (File)
Mar 10 2024, 7:10 PM
Unknown Object (File)
Mar 10 2024, 7:10 PM
Unknown Object (File)
Mar 7 2024, 9:18 PM
Unknown Object (File)
Jan 5 2024, 12:53 PM
Unknown Object (File)
Jan 5 2024, 12:09 PM
Unknown Object (File)
Jan 5 2024, 7:43 AM
Unknown Object (File)
Jan 5 2024, 7:27 AM
View All 21 Files
Subscribers
bcr
imp
pho

Details

Reviewers
kib
Group Reviewers
manpages
Commits
rS357609: MFV r357608: Limit memory usage in xz(1) instead of in tuklib.
Summary

Limit memory usage in xz(1) instead of in tuklib.

Apply upstream 353970510895f6a80adfe60cf71b70a95adfa8bc to
limit memory usage on 32-bit binary to 4020 MiB.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

delphij created this revision.Feb 3 2020, 1:03 AM
Herald added a reviewer: manpages. · View Herald TranscriptFeb 3 2020, 1:03 AM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B29117: Diff 67675.Feb 3 2020, 1:04 AM
bcr accepted this revision as: manpages.Feb 3 2020, 10:19 AM
bcr added a subscriber: bcr.

OK from manpages.

kib accepted this revision.Feb 3 2020, 6:22 PM
kib added a subscriber: pho.

I am fine with bringing the upstream fix. I added Peter so that he can confirm that the issue reported by him does not re-appear.

This revision is now accepted and ready to land.Feb 3 2020, 6:23 PM
pho added a comment.Feb 3 2020, 7:38 PM

I tested this patch on i386 with 8 GB RAM and hw.physmem: 4294963200
LGTM.

Closed by commit rS357609: MFV r357608: Limit memory usage in xz(1) instead of in tuklib. (authored by delphij). · Explain WhyFeb 6 2020, 7:47 AM
This revision was automatically updated to reflect the committed changes.
delphij added a commit: rS357609: MFV r357608: Limit memory usage in xz(1) instead of in tuklib..

Revision Contents
Changeset List

PathSize
head/
contrib/
xz/
src/
common/
6 lines
xz/
32 lines
19 lines

Diff 67855

View Options

head/contrib/xz

Loading...
View Options

head/contrib/xz/src/common/tuklib_physmem.c

Loading...
View Options

head/contrib/xz/src/xz/hardware.c

Loading...
View Options

head/contrib/xz/src/xz/xz.1

Loading...