Page MenuHomeFreeBSD
Differential D23371

Retain only mutually supported TCP options after simultaneous SYN
ClosedPublic
Actions

Authored by rscheff on Jan 26 2020, 6:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 21, 5:48 AM
Unknown Object (File)
Fri, Mar 20, 8:42 PM
Unknown Object (File)
Mon, Mar 16, 11:45 PM
Unknown Object (File)
Wed, Mar 11, 7:47 PM
Unknown Object (File)
Tue, Mar 10, 6:54 AM
Unknown Object (File)
Mon, Mar 9, 7:40 PM
Unknown Object (File)
Mon, Mar 9, 2:35 PM
Unknown Object (File)
Sun, Mar 8, 5:14 PM
View All Files
Subscribers
melifaro

Details

Reviewers
tuexen
rrs
jtl
Group Reviewers
transport
Commits
rS361841: MFC r361346: Retain only mutually supported TCP options after simultaneous SYN
rS361346: Retain only mutually supported TCP options after simultaneous SYN
Summary

When receiving a parallel SYN in SYN-SENT state, remove all the
options only we supported locally before sending the SYN,ACK.

This addresses a consistency issue on parallel opens.

Also, on such a parallel open, the stack could be coaxed into
running with timestamps enabled, even if administratively disabled.

Test Plan

see tcp-testsuite/snippets/syn-rcvd-via-syn-sent-ipv4.pkt

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30966
Build 28675: arc lint + arc unit

Event Timeline

rscheff created this revision.Jan 26 2020, 6:38 PM
Herald added a reviewer: transport. · View Herald TranscriptJan 26 2020, 6:38 PM
Harbormaster completed remote builds in B28929: Diff 67323.Jan 26 2020, 6:38 PM
rscheff updated this revision to Diff 70771.Apr 19 2020, 10:42 AM
  • add bbr stack too
Herald added a subscriber: melifaro. · View Herald TranscriptApr 19 2020, 10:42 AM
Harbormaster completed remote builds in B30608: Diff 70771.Apr 19 2020, 10:42 AM
rrs added inline comments.May 7 2020, 2:59 PM
sys/netinet/tcp_stacks/bbr.c
11605

why this change?

rscheff added inline comments.May 7 2020, 3:01 PM
sys/netinet/tcp_input.c
1635

undo style change.

rscheff updated this revision to Diff 71505.May 7 2020, 3:46 PM
  • undo style change
Harbormaster completed remote builds in B30966: Diff 71505.May 7 2020, 3:46 PM
tuexen accepted this revision.May 21 2020, 1:55 PM
This revision is now accepted and ready to land.May 21 2020, 1:55 PM
rscheff closed this revision.May 21 2020, 9:45 PM
rscheff added a commit: rS361346: Retain only mutually supported TCP options after simultaneous SYN.
rscheff added a commit: rS361841: MFC r361346: Retain only mutually supported TCP options after simultaneous SYN.Jun 5 2020, 6:00 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
9 lines
tcp_stacks/
9 lines
9 lines

Diff 71505

View Options

sys/netinet/tcp_input.c

Loading...
View Options

sys/netinet/tcp_stacks/bbr.c

Loading...
View Options

sys/netinet/tcp_stacks/rack.c

Loading...