Page MenuHomeFreeBSD

Retain only mutually supported TCP options after simultaneous SYN
ClosedPublic

Authored by rscheff on Jan 26 2020, 6:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 11:08 PM
Unknown Object (File)
Fri, Mar 22, 11:08 PM
Unknown Object (File)
Thu, Mar 14, 4:17 AM
Unknown Object (File)
Feb 20 2024, 1:28 PM
Unknown Object (File)
Jan 23 2024, 6:06 AM
Unknown Object (File)
Dec 20 2023, 8:20 AM
Unknown Object (File)
Dec 10 2023, 9:27 AM
Unknown Object (File)
Dec 2 2023, 11:53 AM
Subscribers

Details

Summary

When receiving a parallel SYN in SYN-SENT state, remove all the
options only we supported locally before sending the SYN,ACK.

This addresses a consistency issue on parallel opens.

Also, on such a parallel open, the stack could be coaxed into
running with timestamps enabled, even if administratively disabled.

Test Plan

see tcp-testsuite/snippets/syn-rcvd-via-syn-sent-ipv4.pkt

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30966
Build 28675: arc lint + arc unit

Event Timeline

sys/netinet/tcp_stacks/bbr.c
11605

why this change?

sys/netinet/tcp_input.c
1635

undo style change.

This revision is now accepted and ready to land.May 21 2020, 1:55 PM