Handle a race of collapse with a retrying fault.
ClosedPublic
Actions

Authored by kib on Jan 23 2020, 11:24 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 26, 1:23 AM

	Unknown Object (File)
	Fri, Sep 25, 9:08 PM

	Unknown Object (File)
	Fri, Sep 25, 8:32 AM

	Unknown Object (File)
	Fri, Sep 25, 7:05 AM

	Unknown Object (File)
	Fri, Sep 25, 7:05 AM

	Unknown Object (File)
	Fri, Sep 25, 7:05 AM

	Unknown Object (File)
	Thu, Sep 24, 5:11 PM

	Unknown Object (File)
	Thu, Sep 24, 4:36 PM

View All Files

Subscribers

imp

pho

Details

Reviewers

markj
jeff
alc
dougm

Commits

rS357091: Handle a race of collapse with a retrying fault.

Summary

Both vm_object_scan_all_shadowed() and vm_object_collapse_scan() might observe an invalid page left in the default backing object by the fault handler that retried. Check for the condition and refuse to collapse.

Reported by: pho

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Jan 23 2020, 11:24 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 23 2020, 11:24 AM

Harbormaster completed remote builds in B28870: Diff 67192.Jan 23 2020, 11:24 AM

kib added a subscriber: pho.Jan 23 2020, 11:24 AM

The goto is unfortunate but I see that without the loop becomes even weirder

This revision is now accepted and ready to land.Jan 24 2020, 1:52 AM

I completed a full stress2 test and ran the original problem test for 3 hours.
LGTM.

Closed by commit rS357091: Handle a race of collapse with a retrying fault. (authored by kib). · Explain WhyJan 24 2020, 7:42 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS357091: Handle a race of collapse with a retrying fault..

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

vm_object.c

48 lines

Diff 67258

View Options

Handle a race of collapse with a retrying fault.ClosedPublicActions