Page MenuHomeFreeBSD

uma: fix zone domain overlaying pcpu cache with disabled cpus
ClosedPublic

Authored by rlibby on Jan 22 2020, 6:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 6:14 PM
Unknown Object (File)
Nov 16 2024, 8:06 AM
Unknown Object (File)
Nov 14 2024, 12:56 PM
Unknown Object (File)
Oct 29 2024, 7:25 AM
Unknown Object (File)
Oct 18 2024, 2:39 AM
Unknown Object (File)
Oct 7 2024, 10:35 AM
Unknown Object (File)
Oct 7 2024, 10:35 AM
Unknown Object (File)
Oct 7 2024, 10:35 AM

Details

Summary

UMA zone structures have two arrays at the end which are sized according
to the machine: an array of cpu count length, and an array of NUMA
domain count length. The CPU counting was wrong in the case where some
CPUs are disabled (when mp_ncpus != mp_maxid + 1), and this caused the
second array to be overlaid with the first.

Reported by: olivier

Test Plan

Disable some CPUs. Olivier did this with

machdep.hyperthreading_allowed="0"

but I did not have a hyperthreading machine to test so I did this from
the loader:

set hint.lapic.1.disabled=1
set hint.lapic.3.disabled=1
set hint.lapic.5.disabled=1
set hint.lapic.7.disabled=1
set hint.lapic.9.disabled=1
set hint.lapic.11.disabled=1
set hint.lapic.13.disabled=1
set hint.lapic.15.disabled=1

Then:
kyua test -k /usr/tests/sys/Kyuafile

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28847
Build 26853: arc lint + arc unit