Page MenuHomeFreeBSD

Move the fault getpages code into its own function.
ClosedPublic

Authored by jeff on Jan 22 2020, 3:03 AM.
Tags
None
Referenced Files
F160050219: D23311.id67183.diff
Sat, Jun 20, 10:06 PM
F160035247: D23311.id.diff
Sat, Jun 20, 7:02 PM
Unknown Object (File)
Sat, Jun 20, 10:42 AM
Unknown Object (File)
Tue, Jun 16, 1:27 PM
Unknown Object (File)
Sun, Jun 14, 12:34 PM
Unknown Object (File)
Sat, Jun 13, 4:22 AM
Unknown Object (File)
Sat, Jun 13, 1:52 AM
Unknown Object (File)
Wed, Jun 10, 6:43 PM
Subscribers

Details

Summary

I left the readahead in the main loop because we don't need to repeat the dropbehind. However, storing the cached entry variables before unlocking the map was only done once before. I don't think this was important to the algorithm nor is it especially expensive.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jeff added reviewers: alc, dougm, kib, markj.
jeff set the repository for this revision to rS FreeBSD src repository - subversion.
sys/vm/vm_fault.c
1088 ↗(On Diff #67132)

Please do not do this. You are mixing VM_PAGER_XXX (pager errors namespace) and KERN_XXX (Mach errors).

This is arguably incorrect in particular because the numeric values intersect. Translate the rest of errors into KERN_ as well.

sys/vm/vm_fault.c
1088 ↗(On Diff #67132)

ah yes. Will do.

I would argue that we should convert the whole mess to errno but not today.

Correct return values. Don't send pager errors back to vm_fault().

This revision is now accepted and ready to land.Jan 22 2020, 9:11 PM