Move map lookup into a separate function.
ClosedPublic
Actions

Authored by jeff on Jan 21 2020, 7:42 PM.

Details

Reviewers

alc
dougm
kib
markj

Commits

rS357021: (fault 2/9) Move map lookup into a dedicated function.

Summary

I'm not totally in love with the vm return codes. However, I am following a pattern that exists elsewhere in this file where RESOURCE_SHORTAGE means restart.

This should be functionally identical.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jeff created this revision.Jan 21 2020, 7:42 PM

Harbormaster completed remote builds in B28824: Diff 67114.Jan 21 2020, 7:42 PM

jeff edited the summary of this revision. (Show Details)Jan 21 2020, 7:51 PM

jeff added reviewers: alc, dougm, kib, markj.

jeff set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJan 21 2020, 7:51 PM

kib accepted this revision.Jan 21 2020, 9:00 PM

kib added inline comments.

sys/vm/vm_fault.c
878 ↗	(On Diff #67114)	You can write this cleaner IMO: if (result == KERN_RESOURCE_SHORTAGE) goto RetryFault; if (result != KERN_SUCCESS) return (result);