powerpc: Fix the NUMA domain list on powernv
ClosedPublic
Actions

Authored by jhibbits on Jan 17 2020, 12:13 AM.

Details

Reviewers

nwhitehorn
bdragon
luporl

Group Reviewers

PowerPC

Commits

rS356858: powerpc: Fix the NUMA domain list on powernv

Summary

Consolidate the NUMA associativity handling into a platform function.
Non-NUMA platforms will just fall back to the default (0). Currently
only implemented for powernv, which uses a lookup table to map the
device tree associativity into a system NUMA domain.

Fixes hangs on powernv after r356534, and corrects a fairly longstanding
bug in powernv's NUMA handling, which ended up using domains 1 and 2 for
devices and memory on power9, while CPUs were bound to domains 0 and 1.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits created this revision.Jan 17 2020, 12:13 AM

Harbormaster completed remote builds in B28713: Diff 66875.Jan 17 2020, 12:13 AM

luporl added a subscriber: luporl.Jan 17 2020, 12:21 PM

luporl added inline comments.

sys/powerpc/powernv/platform_powernv.c
154–157 ↗	(On Diff #66875)	'platform_associativity' (static) isn't being used anywhere in this file 'refpoints' is not used anywhere in this function. Empty if block? Maybe is there some code missing here?
532 ↗	(On Diff #66875)	Not sure, but shouldn't we use an index from refpoints here, instead of always 3 in associativity[]?

jhibbits added inline comments.Jan 17 2020, 4:09 PM

sys/powerpc/powernv/platform_powernv.c
154–157 ↗	(On Diff #66875)	I was trying several things in this. I meant to delete this finally, and revisit it later, but I'll use it instead.
532 ↗	(On Diff #66875)	Yes, I was going to just leave it as parity with the existing code, but I'll do single-level NUMA (index 0) for now. We should revisit it again at some point, to handle multi-level NUMA, but I don't think FreeBSD in general supports that yet.