Page MenuHomeFreeBSD

hexdump test: take into account byte order
ClosedPublic

Authored by renato.riolino_eldorado.org.br on Jan 15 2020, 2:25 PM.
Tags
Referenced Files
F168364898: D23191.id69087.diff
Thu, Aug 27, 7:17 PM
F168241345: D23191.id69087.diff
Thu, Aug 27, 3:17 AM
F168223778: D23191.id69087.diff
Thu, Aug 27, 12:42 AM
F168209367: D23191.id.diff
Wed, Aug 26, 10:04 PM
F168208556: D23191.id66787.diff
Wed, Aug 26, 9:57 PM
F168206642: D23191.diff
Wed, Aug 26, 9:39 PM
Unknown Object (File)
Tue, Aug 25, 6:08 PM
Unknown Object (File)
Sun, Aug 16, 8:51 PM
Subscribers

Details

Summary

Hexdump test was failling on big endian systems when testing decimal, octal and hexa outputs

Test Plan

cd /usr/src/usr.bin/hexdump/tests/
make
make install
kyua test -k /usr/tests/usr.bin/hexdump/Kyuafile

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Seems like a good approach to me; the only nit I have to offer is that we oftentimes prefer spelling these "el" and "eb," but I suspect we have enough of a mix that it doesn't matter.

This revision is now accepted and ready to land.Jan 15 2020, 2:36 PM

Fix speeling "be" and "le" to "eb" and "el"

This revision now requires review to proceed.Jan 15 2020, 4:07 PM

Perfect, thanks! =-) May I ask which big-endian arch you're running these tests on? This is just my curiosity- the tests are indisputably broken as-is.

This revision is now accepted and ready to land.Jan 15 2020, 4:10 PM

Perfect, thanks! =-) May I ask which big-endian arch you're running these tests on? This is just my curiosity- the tests are indisputably broken as-is.

Sure! I'm on ppc64 :p

This revision was automatically updated to reflect the committed changes.