Page MenuHomeFreeBSD

hexdump test: take into account byte order
ClosedPublic

Authored by renato.riolino_eldorado.org.br on Jan 15 2020, 2:25 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Dec 8, 11:06 PM
Unknown Object (File)
Sun, Nov 24, 4:28 AM
Unknown Object (File)
Nov 11 2024, 6:34 AM
Unknown Object (File)
Sep 30 2024, 2:31 PM
Unknown Object (File)
Sep 23 2024, 8:52 AM
Unknown Object (File)
Sep 23 2024, 8:52 AM
Unknown Object (File)
Sep 19 2024, 7:17 PM
Unknown Object (File)
Sep 18 2024, 4:07 AM
Subscribers

Details

Summary

Hexdump test was failling on big endian systems when testing decimal, octal and hexa outputs

Test Plan

cd /usr/src/usr.bin/hexdump/tests/
make
make install
kyua test -k /usr/tests/usr.bin/hexdump/Kyuafile

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Seems like a good approach to me; the only nit I have to offer is that we oftentimes prefer spelling these "el" and "eb," but I suspect we have enough of a mix that it doesn't matter.

This revision is now accepted and ready to land.Jan 15 2020, 2:36 PM

Fix speeling "be" and "le" to "eb" and "el"

This revision now requires review to proceed.Jan 15 2020, 4:07 PM

Perfect, thanks! =-) May I ask which big-endian arch you're running these tests on? This is just my curiosity- the tests are indisputably broken as-is.

This revision is now accepted and ready to land.Jan 15 2020, 4:10 PM

Perfect, thanks! =-) May I ask which big-endian arch you're running these tests on? This is just my curiosity- the tests are indisputably broken as-is.

Sure! I'm on ppc64 :p

This revision was automatically updated to reflect the committed changes.