[PowerPC] Fix libllvmminimal build when building from powerpc64 ELFv1.
ClosedPublic
Actions

Authored by bdragon on Jan 7 2020, 8:40 PM.

Tags

Referenced Files

	F167058732: D23072.diff
	Tue, Aug 18, 8:16 PM

	Unknown Object (File)
	Tue, Aug 11, 4:16 PM

	Unknown Object (File)
	Mon, Aug 10, 1:55 PM

	Unknown Object (File)
	Sun, Aug 9, 5:09 PM

	Unknown Object (File)
	Sun, Aug 9, 5:08 PM

	Unknown Object (File)
	Fri, Aug 7, 9:07 PM

	Unknown Object (File)
	Fri, Aug 7, 12:45 PM

	Unknown Object (File)
	Thu, Aug 6, 2:11 PM

Subscribers

Contributor Reviews (src)

Details

Reviewers

dim

Commits

rS356479: [PowerPC] Fix libllvmminimal build when building from powerpc64 ELFv1.

Summary

When building an elfv2 bootstrap toolchain with gcc8 / binutils ld.bfd, the build fails in libllvmminimal due to missing references (as ld.bfd is pickier about undefined references than lld)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdragon created this revision.Jan 7 2020, 8:40 PM

Herald added subscribers: Contributor Reviews (src), alfredo, luporl and 2 others. · View Herald TranscriptJan 7 2020, 8:40 PM

bdragon added a reviewer: dim.Jan 7 2020, 8:41 PM

LGTM

Sure, this is unfortunately a rather finicky area, and needs several tries to get right for all platforms...

This revision is now accepted and ready to land.Jan 7 2020, 9:26 PM

Closed by commit rS356479: [PowerPC] Fix libllvmminimal build when building from powerpc64 ELFv1. (authored by bdragon). · Explain WhyJan 7 2020, 10:45 PM

This revision was automatically updated to reflect the committed changes.

bdragon added a commit: rS356479: [PowerPC] Fix libllvmminimal build when building from powerpc64 ELFv1..

Revision Contents
Changeset List

Path

Size

head/

lib/

clang/

libllvmminimal/

Makefile

1 line

Diff 66467

View Options

head/lib/clang/libllvmminimal/Makefile

[PowerPC] Fix libllvmminimal build when building from powerpc64 ELFv1.ClosedPublicActions