Page MenuHomeFreeBSD

kern_sysctl: make sysctl.debug work as intended
ClosedPublic

Authored by kaktus on Jan 6 2020, 6:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 11, 9:07 PM
Unknown Object (File)
Mar 7 2025, 2:08 AM
Unknown Object (File)
Mar 6 2025, 4:07 AM
Unknown Object (File)
Mar 4 2025, 4:10 PM
Unknown Object (File)
Mar 4 2025, 4:02 PM
Unknown Object (File)
Mar 4 2025, 2:48 PM
Unknown Object (File)
Mar 4 2025, 3:35 AM
Unknown Object (File)
Feb 19 2025, 6:40 PM
Subscribers
None

Details

Summary

r136999 introduced SYSTCL_DEBUG but apparently "opt_sysctl.h" was never included making the option ignored.

r322954 introduced sysctl.reuse_test with OID number equal to 0, effectively shadowing the very special sysctl.debug one. Use OID_AUTO as it doesn't need any special treatment.

Test Plan

compile kernel with options SYSCTL_DEBUG and run:

sysctl sysctl.debug

observe kern.msgbuf

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kaktus retitled this revision from kern_sysctl: make SYSTCL_DEBUG work again to kern_sysctl: make sysctl.debug work as intended.Jan 6 2020, 6:52 PM
kaktus edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Jan 6 2020, 7:33 PM
This revision was automatically updated to reflect the committed changes.