kern_sysctl: make sysctl.debug work as intended
ClosedPublic
Actions

Authored by kaktus on Jan 6 2020, 6:28 PM.

Details

Reviewers

imp
kib
mjg
emaste

Commits

rS356425: kern_sysctl: make sysctl.debug work as intended

Summary

r136999 introduced SYSTCL_DEBUG but apparently "opt_sysctl.h" was never included making the option ignored.

r322954 introduced sysctl.reuse_test with OID number equal to 0, effectively shadowing the very special sysctl.debug one. Use OID_AUTO as it doesn't need any special treatment.

Test Plan

compile kernel with options SYSCTL_DEBUG and run:

sysctl sysctl.debug

observe kern.msgbuf

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kaktus created this revision.Jan 6 2020, 6:28 PM

kaktus added a reviewer: emaste.Jan 6 2020, 6:30 PM

kaktus retitled this revision from kern_sysctl: make SYSTCL_DEBUG work again to kern_sysctl: make sysctl.debug work as intended.Jan 6 2020, 6:52 PM

kaktus edited the test plan for this revision. (Show Details)

kib accepted this revision.Jan 6 2020, 7:33 PM

This revision is now accepted and ready to land.Jan 6 2020, 7:33 PM

Closed by commit rS356425: kern_sysctl: make sysctl.debug work as intended (authored by kaktus). · Explain WhyJan 6 2020, 7:48 PM

This revision was automatically updated to reflect the committed changes.

kaktus added a commit: rS356425: kern_sysctl: make sysctl.debug work as intended.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_sysctl.c

6 lines

Diff 66416

View Options

kern_sysctl: make sysctl.debug work as intendedClosedPublicActions