2019-12-31 turn off GCC 4.2.1 build by default
ClosedPublic
Actions

Authored by emaste on Jan 3 2020, 7:18 PM.

Details

Reviewers

imp
jhb

Commits

rS356367: Do not build GCC 4.2.1 by default for any CPU architecture

Summary

By default set to NO:

GCC
GCC_BOOTSTRAP
GNUCXX

https://lists.freebsd.org/pipermail/freebsd-arch/2019-August/019674.html

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Jan 3 2020, 7:18 PM

Herald added a subscriber: bdrewery. · View Herald TranscriptJan 3 2020, 7:18 PM

emaste added a subscriber: lwhsu.Jan 3 2020, 7:25 PM

Thanks.

This revision is now accepted and ready to land.Jan 3 2020, 7:35 PM

sparc64 LINT failure:

In file included from /scratch/tmp/emaste/freebsd/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/rack_bbr_common.c:96:0:
/scratch/tmp/emaste/freebsd/sys/netinet/tcp_fsm.h:88:15: error: 'tcp_outflags' defined but not used [-Werror=unused-variable]
 static u_char tcp_outflags[TCP_NSTATES] = {
               ^~~~~~~~~~~~

We probably need to ensure that lwhsu@ switches jobs over that will start failing in Jenkins after this. Li-wen was hesitant to do this until we turned off GCC 4.2.1, but I think we should preemptively change Jenkins to use external toolchain for mips and sparc64 for head build jobs before committing this so that we don't break them.

Closed by commit rS356367: Do not build GCC 4.2.1 by default for any CPU architecture (authored by emaste). · Explain WhyJan 5 2020, 2:48 AM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS356367: Do not build GCC 4.2.1 by default for any CPU architecture.