Page MenuHomeFreeBSD

2019-12-31 turn off GCC 4.2.1 build by default
ClosedPublic

Authored by emaste on Jan 3 2020, 7:18 PM.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emaste created this revision.Jan 3 2020, 7:18 PM
emaste added a subscriber: lwhsu.Jan 3 2020, 7:25 PM
imp accepted this revision.Jan 3 2020, 7:35 PM

Thanks.

This revision is now accepted and ready to land.Jan 3 2020, 7:35 PM
emaste added a comment.Jan 3 2020, 9:09 PM

sparc64 LINT failure:

In file included from /scratch/tmp/emaste/freebsd/sys/modules/tcp/bbr/../../../netinet/tcp_stacks/rack_bbr_common.c:96:0:
/scratch/tmp/emaste/freebsd/sys/netinet/tcp_fsm.h:88:15: error: 'tcp_outflags' defined but not used [-Werror=unused-variable]
 static u_char tcp_outflags[TCP_NSTATES] = {
               ^~~~~~~~~~~~
jhb accepted this revision.Jan 3 2020, 9:43 PM

We probably need to ensure that lwhsu@ switches jobs over that will start failing in Jenkins after this. Li-wen was hesitant to do this until we turned off GCC 4.2.1, but I think we should preemptively change Jenkins to use external toolchain for mips and sparc64 for head build jobs before committing this so that we don't break them.

This revision was automatically updated to reflect the committed changes.