Remove set_page_dirty_lock().
ClosedPublic
Actions

Authored by markj on Jan 2 2020, 3:13 PM.

Details

Reviewers

johalun
• hselasky

Group Reviewers

x11

Commits

rS356281: Remove set_page_dirty_lock().

Summary

Its use of the page lock is incorrect, and it is not used by the DRM
modules.

I do not plan to MFC this.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28439
Build 26508: arc lint + arc unit

Event Timeline

markj created this revision.Jan 2 2020, 3:13 PM

Herald added a subscriber: emaste. · View Herald TranscriptJan 2 2020, 3:13 PM

Harbormaster completed remote builds in B28439: Diff 66246.Jan 2 2020, 3:13 PM

markj edited the summary of this revision. (Show Details)Jan 2 2020, 3:14 PM

markj added reviewers: johalun, • hselasky.

Please MFC to 11 and 12, to keep code in synch.

Yes, this function is not used anywhere.

This revision is now accepted and ready to land.Jan 2 2020, 5:39 PM

In D23002#504097, @hselasky wrote:

Please MFC to 11 and 12, to keep code in synch.

Yes, this function is not used anywhere.

I did not check that older versions of the DRM modules (used on 12, for instance) do not use this function. If you are confident that they do not, I will MFC.

At least not DRM for -13. @johalun : This is job for you :-)

• hselasky added a reviewer: x11.Jan 2 2020, 5:58 PM

Closed by commit rS356281: Remove set_page_dirty_lock(). (authored by markj). · Explain WhyJan 2 2020, 7:29 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS356281: Remove set_page_dirty_lock()..

Herald added a subscriber: imp. · View Herald TranscriptJan 2 2020, 7:29 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

mm.h

8 lines

Diff 66246

View Options

sys/compat/linuxkpi/common/include/linux/mm.h

Remove set_page_dirty_lock().ClosedPublicActions