Page MenuHomeFreeBSD

Remove set_page_dirty_lock().
ClosedPublic

Authored by markj on Jan 2 2020, 3:13 PM.

Details

Summary

Its use of the page lock is incorrect, and it is not used by the DRM
modules.

I do not plan to MFC this.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj created this revision.Jan 2 2020, 3:13 PM
markj edited the summary of this revision. (Show Details)Jan 2 2020, 3:14 PM
markj added reviewers: johalun, hselasky.
hselasky accepted this revision.Jan 2 2020, 5:39 PM

Please MFC to 11 and 12, to keep code in synch.

Yes, this function is not used anywhere.

This revision is now accepted and ready to land.Jan 2 2020, 5:39 PM
markj added a comment.Jan 2 2020, 5:40 PM

Please MFC to 11 and 12, to keep code in synch.
Yes, this function is not used anywhere.

I did not check that older versions of the DRM modules (used on 12, for instance) do not use this function. If you are confident that they do not, I will MFC.

At least not DRM for -13. @johalun : This is job for you :-)

hselasky added a reviewer: x11.Jan 2 2020, 5:58 PM
This revision was automatically updated to reflect the committed changes.