Page MenuHomeFreeBSD

New port: x11/i3lock-color, slightly improved screen locker based on slock
AbandonedPublic

Authored by jacob_jwfh.ca on Dec 28 2019, 4:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 4:42 PM
Unknown Object (File)
Fri, Apr 12, 9:31 AM
Unknown Object (File)
Wed, Apr 10, 2:29 PM
Unknown Object (File)
Wed, Apr 10, 1:48 PM
Unknown Object (File)
Wed, Apr 10, 10:02 AM
Unknown Object (File)
Thu, Mar 28, 3:51 AM
Unknown Object (File)
Mar 13 2024, 11:23 PM
Unknown Object (File)
Mar 13 2024, 11:23 PM

Details

Reviewers
None
Group Reviewers
Contributor Reviewers (ports)
Summary

Adding a new port for the [i3lock-color](https://github.com/Raymo111/i3lock-color) fork of i3lock.

From the project repo:

Many little improvements have been made to i3lock over time:

  • i3lock forks, so you can combine it with an alias to suspend to RAM (run i3lock && echo mem > /sys/power/state to get a locked screen after waking up your computer from suspend to RAM)
  • You can specify either a background color or an image (JPG or PNG), which will be displayed while your screen is locked.
  • You can specify whether i3lock should bell upon a wrong password.
  • i3lock uses PAM and therefore is compatible with LDAP etc. On OpenBSD i3lock uses the bsd_auth(3) framework.

Additional features in this fork: you can also specify additional options, as detailed in the manpage. This includes, but is not limited to, the following:

  • Color options for the following:
    • verification ring
    • interior ring color
    • ring interior line color
    • key highlight color
    • backspace highlight color
    • text colors for most/all strings
    • Changing all of the above depending on PAM's authentication status
  • Blurring the current screen and using that as the lock background
  • Showing a clock in the indicator
  • refreshing on a timer, instead of on each keypress
  • Positioning the various UI elements
  • Changing the ring radius and thickness, as well as text size
  • Passthrough media keys
  • A new bar indicator, which replaces the ring indicator with its own set of options
    • An experimental thread for driving the redraw ticks, so that things like the bar/clock still update when PAM is blocking
Test Plan

Builds on FreeBSD 12.1-RELEASE-p4 GENERIC amd64 and works the way it should.

I have not been able to test on other architectures.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 31054
Build 28756: arc lint + arc unit

Event Timeline

Testing on fresh install revealed issues with PAM. I will update the revision when a workaround is found.

For now, the revision is not ready to merge.

linimon retitled this revision from New port: i3lock-color to New port: x11/i3lock-color, slightly improved screen locker based on slock.Dec 28 2019, 9:25 PM

Updated package list to change file mode of i3lock to 4755, according to what I have read on this webpage and the PLIST_FILES assignment in the i3lock port's Makefile.

The project has been declared unmaintained. See https://github.com/PandorasFox/i3lock-color#this-project-is-not-maintained. Adding an unmaintained project might not be the best idea in the long run.

x11/i3lock-color/Makefile
15

Should be USE_GNOME=cairo

23

Should be USES=jpeg

25

Missing USES=xorg

28

Remove. It is the default.

34–36

Note that share/man is now a valid location to install man pages into, so maybe you can remove MANDIR again here.

i3lock-color uses autotools. Is the configure script really so broken that you need override a bunch of stuff via MAKE_ARGS? Normally it should be fine without it.

38

I doubt it conflicts during building with i3lock. Maybe it should be CONFLICTS_INSTALL instead.

jacob_jwfh.ca edited the summary of this revision. (Show Details)
jacob_jwfh.ca edited the test plan for this revision. (Show Details)

Just found that the recently added https://www.freshports.org/x11/i3lock-color might do the same thing...

Hi @jacob_jwfh.ca,

As the committer of the mentioned PR https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257664, I was not aware of your patch in Phabricator and only looked in Bugzilla. I apologize for that.

Well, that the port already exists and Fadel <fjachuf@gmail.com> is entered as maintainer, this probably can't be changed anymore :(

Now I wonder if some of the differences between the patches should be merged. I will try to discuss this with Fadel.