HomeFreeBSD

x11/i3lock-color: Add new port: Improved i3lock version

Description

x11/i3lock-color: Add new port: Improved i3lock version

A modern version of i3lock with color functionality and other features.

https://github.com/Raymo111/i3lock-color

PR: 257664

Details

Provenance
fjachuf_gmail.comAuthored on Aug 9 2021, 5:06 AM
rhurlinCommitted on Aug 9 2021, 5:12 AM
Parents
R11:962be10550ee: databases/mongodb44: Update to 4.4.8
Branches
Unknown
Tags
Unknown

Event Timeline

@rhurlin, @fjachuf_gmail.com, @lwhsu,

Thanks for leaving a message on my patch about the duplication. I am glad to see that this port will now be available for users! I'll close my patch.

I've left a couple of comments that my reviewers suggested I change in my patch. Hope this helps and might be able to make it into a future version of the port.

Jacob

/x11/i3lock-color/Makefile
11

Should be USE_GNOME=cairo

32–34

Are you certain that all of these MAKE_ARGS are strictly necessary? I too had all of these in my Phabricator PR but was asked in the review process to try building without them and it appeared to work without the overridden MAKE_ARGS.

46–48

The package source provides documentation files with which we can make a DOCS option for the user:

DOC_FILES=	CHANGELOG README.md
DOCS_PLIST_FILES=	${DOC_FILES:S|^|${DOCSDIR_REL}/|}

OPTIONS_DEFINE=	DOCS

post-install:
	${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/i3lock
	${RM} ${STAGEDIR}${PREFIX}/etc/pam.d/i3lock

post-install-DOCS-on:
	${MKDIR} ${STAGEDIR}${DOCSDIR}
	${INSTALL_DATA} ${DOC_FILES:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}