Page MenuHomeFreeBSD

Fix the powerpc copyout fixup from r356113
ClosedPublic

Authored by jhibbits on Dec 27 2019, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 26 2024, 2:39 AM
Unknown Object (File)
Nov 23 2024, 12:49 PM
Unknown Object (File)
Sep 23 2024, 11:48 PM
Unknown Object (File)
Sep 19 2024, 8:33 PM
Unknown Object (File)
Sep 18 2024, 7:19 AM
Unknown Object (File)
Sep 2 2024, 3:54 PM
Unknown Object (File)
Aug 28 2024, 12:11 PM
Unknown Object (File)
Aug 22 2024, 8:31 PM
Subscribers

Details

Summary

r356113 used an older patch, which predated the
freebsd_copyout_auxargs() addition. Fix this by using a private
powerpc_copyout_auxargs() instead, and keep it private to powerpc, not in MI
files.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28334
Build 26432: arc lint + arc unit

Event Timeline

Thank you for fixing this.

sys/powerpc/include/elf.h
141

I would suggest to keep the symbols at the AT_ namespace, i.e. name them AT_OLD_NULL etc.

sys/powerpc/powerpc/elf_common.c
31

The file lacks $FreeBSD$ tag, which will trigger the pre-commit hook. I wrote it there because you do not need to use any includes in this file, they should be provided by consumers.

36

style issue: initialization in declaration.

Tests went good.

It can boot an pre-130007 (tested with elfv2) world without crashing, and the old programs continue to work. It can also run new binaries (as expected.)

This revision is now accepted and ready to land.Dec 27 2019, 5:13 PM
This revision now requires review to proceed.Dec 27 2019, 5:17 PM
This revision is now accepted and ready to land.Dec 27 2019, 5:22 PM
This revision was automatically updated to reflect the committed changes.