Fix the powerpc copyout fixup from r356113
ClosedPublic
Actions

Authored by jhibbits on Dec 27 2019, 4:57 PM.

Details

Reviewers

kib
brooks
bdragon

Commits

rS356129: Fix the powerpc copyout fixup from r356113

Summary

r356113 used an older patch, which predated the
freebsd_copyout_auxargs() addition. Fix this by using a private
powerpc_copyout_auxargs() instead, and keep it private to powerpc, not in MI
files.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits created this revision.Dec 27 2019, 4:57 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 27 2019, 4:57 PM

Harbormaster completed remote builds in B28334: Diff 66024.Dec 27 2019, 4:57 PM

Thank you for fixing this.

sys/powerpc/include/elf.h
141 ↗	(On Diff #66024)	I would suggest to keep the symbols at the AT_ namespace, i.e. name them AT_OLD_NULL etc.
sys/powerpc/powerpc/elf_common.c
31 ↗	(On Diff #66024)	The file lacks $FreeBSD$ tag, which will trigger the pre-commit hook. I wrote it there because you do not need to use any includes in this file, they should be provided by consumers.
36 ↗	(On Diff #66024)	style issue: initialization in declaration.

Tests went good.

It can boot an pre-130007 (tested with elfv2) world without crashing, and the old programs continue to work. It can also run new binaries (as expected.)

This revision is now accepted and ready to land.Dec 27 2019, 5:13 PM

Address @kib's feedback.

This revision now requires review to proceed.Dec 27 2019, 5:17 PM

Harbormaster completed remote builds in B28335: Diff 66025.Dec 27 2019, 5:17 PM

kib accepted this revision.Dec 27 2019, 5:22 PM

This revision is now accepted and ready to land.Dec 27 2019, 5:22 PM

Closed by commit rS356129: Fix the powerpc copyout fixup from r356113 (authored by jhibbits). · Explain WhyDec 27 2019, 5:38 PM

This revision was automatically updated to reflect the committed changes.

jhibbits added a commit: rS356129: Fix the powerpc copyout fixup from r356113.