Page MenuHomeFreeBSD
Differential D22834

Convert routing stats to VNET_PCPUSTAT
ClosedPublic
Actions

Authored by olivier on Dec 16 2019, 5:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 27, 10:06 PM
Unknown Object (File)
Thu, Nov 20, 9:23 PM
Unknown Object (File)
Thu, Nov 20, 9:16 PM
Unknown Object (File)
Thu, Nov 20, 9:16 PM
Unknown Object (File)
Thu, Nov 20, 9:07 PM
Unknown Object (File)
Oct 28 2025, 7:49 AM
Unknown Object (File)
Oct 14 2025, 10:45 PM
Unknown Object (File)
Oct 14 2025, 10:45 PM
View All 75 Files
Subscribers
ae
imp
Contributor Reviews (src)

Details

Reviewers
glebius
melifaro
ae
Commits
rS355840: Convert routing statistics to VNET_PCPUSTAT.
Summary

Looks like those old stats should be converted to VNET_PCPUSTAT

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28177
Build 26308: arc lint + arc unit

Event Timeline

olivier created this revision.Dec 16 2019, 5:51 PM
Herald added subscribers: Contributor Reviews (src), ae, imp. · View Herald TranscriptDec 16 2019, 5:51 PM
Harbormaster completed remote builds in B28177: Diff 65709.Dec 16 2019, 5:51 PM
olivier added reviewers: glebius, melifaro, ae.Dec 16 2019, 5:52 PM
melifaro added inline comments.Dec 16 2019, 6:58 PM
sys/net/route.c
668

Nit: previous logic increased that under if (error == 0) condition

sys/net/route.h
257

Do we need counters that can go backwards ? :-)
On a serious note, zero statistics can potentially be useful.

melifaro added inline comments.Dec 16 2019, 7:00 PM
sys/net/route.h
257

Sorry, I meant macro, zeroing current statistics counters.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 17 2019, 2:02 AM
Closed by commit rS355840: Convert routing statistics to VNET_PCPUSTAT. (authored by glebius). · Explain Why
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rS355840: Convert routing statistics to VNET_PCPUSTAT..

Revision Contents
Changeset List

PathSize
sys/
net/
25 lines
19 lines
usr.bin/
netstat/
12 lines

Diff 65709

View Options

sys/net/route.h

Loading...
View Options

sys/net/route.c

Loading...
View Options

usr.bin/netstat/route.c

Loading...