Paths

Table of Contentst

Differential D22834

Convert routing stats to VNET_PCPUSTAT
ClosedPublic
Actions

Authored by olivier on Dec 16 2019, 5:51 PM.

Tags

None

Referenced Files

	F174470246: D22834.id65709.diff
	Sat, Oct 3, 12:25 PM

	F174463368: D22834.id65737.diff
	Sat, Oct 3, 11:09 AM

	F174356560: D22834.diff
	Fri, Oct 2, 3:55 PM

	Unknown Object (File)
	Fri, Oct 2, 11:24 AM

	Unknown Object (File)
	Tue, Sep 29, 4:13 PM

	Unknown Object (File)
	Tue, Sep 29, 1:56 PM

	Unknown Object (File)
	Tue, Sep 29, 12:57 PM

	Unknown Object (File)
	Tue, Sep 29, 3:56 AM

Subscribers

Contributor Reviews (src)

Details

Reviewers

glebius
melifaro
ae

Commits

rS355840: Convert routing statistics to VNET_PCPUSTAT.

Summary

Looks like those old stats should be converted to VNET_PCPUSTAT

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olivier created this revision.Dec 16 2019, 5:51 PM

Herald added subscribers: Contributor Reviews (src), ae, imp. · View Herald TranscriptDec 16 2019, 5:51 PM

Harbormaster completed remote builds in B28177: Diff 65709.Dec 16 2019, 5:51 PM

olivier added reviewers: glebius, melifaro, ae.Dec 16 2019, 5:52 PM

melifaro added inline comments.Dec 16 2019, 6:58 PM

sys/net/route.c
668 ↗	(On Diff #65709)	Nit: previous logic increased that under `if (error == 0)` condition
sys/net/route.h
257 ↗	(On Diff #65709)	Do we need counters that can go backwards ? :-) On a serious note, zero statistics can potentially be useful.

melifaro added inline comments.Dec 16 2019, 7:00 PM

sys/net/route.h
257 ↗	(On Diff #65709)	Sorry, I meant macro, zeroing current statistics counters.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 17 2019, 2:02 AM

Closed by commit rS355840: Convert routing statistics to VNET_PCPUSTAT. (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rS355840: Convert routing statistics to VNET_PCPUSTAT..

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

13 lines

24 lines

usr.bin/

netstat/

12 lines

Diff 65737

head/sys/net/route.h

Loading...

head/sys/net/route.c

Loading...

head/usr.bin/netstat/route.c

Loading...