Page MenuHomeFreeBSD
Differential D22834

Convert routing stats to VNET_PCPUSTAT
ClosedPublic
Actions

Authored by olivier on Dec 16 2019, 5:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 12, 3:01 AM
Unknown Object (File)
Fri, May 9, 11:42 AM
Unknown Object (File)
Wed, May 7, 1:37 AM
Unknown Object (File)
Sat, Apr 26, 2:47 PM
Unknown Object (File)
Sun, Apr 20, 9:42 AM
Unknown Object (File)
Sun, Apr 20, 9:18 AM
Unknown Object (File)
Sun, Apr 20, 8:57 AM
Unknown Object (File)
Sun, Apr 20, 8:54 AM
View All 55 Files
Subscribers
ae
imp
Contributor Reviews (src)

Details

Reviewers
glebius
melifaro
ae
Commits
rS355840: Convert routing statistics to VNET_PCPUSTAT.
Summary

Looks like those old stats should be converted to VNET_PCPUSTAT

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olivier created this revision.Dec 16 2019, 5:51 PM
Herald added subscribers: Contributor Reviews (src), ae, imp. · View Herald TranscriptDec 16 2019, 5:51 PM
Harbormaster completed remote builds in B28177: Diff 65709.Dec 16 2019, 5:51 PM
olivier added reviewers: glebius, melifaro, ae.Dec 16 2019, 5:52 PM
melifaro added inline comments.Dec 16 2019, 6:58 PM
sys/net/route.c
668 ↗(On Diff #65709)

Nit: previous logic increased that under if (error == 0) condition

sys/net/route.h
257 ↗(On Diff #65709)

Do we need counters that can go backwards ? :-)
On a serious note, zero statistics can potentially be useful.

melifaro added inline comments.Dec 16 2019, 7:00 PM
sys/net/route.h
257 ↗(On Diff #65709)

Sorry, I meant macro, zeroing current statistics counters.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 17 2019, 2:02 AM
Closed by commit rS355840: Convert routing statistics to VNET_PCPUSTAT. (authored by glebius). · Explain Why
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rS355840: Convert routing statistics to VNET_PCPUSTAT..

Revision Contents
Changeset List

PathSize
head/
sys/
net/
13 lines
24 lines
usr.bin/
netstat/
12 lines

Diff 65737

View Options

head/sys/net/route.h

Loading...
View Options

head/sys/net/route.c

Loading...
View Options

head/usr.bin/netstat/route.c

Loading...