Page MenuHomeFreeBSD

pfctl: Warn users when they run into kernel limits
ClosedPublic

Authored by kp on Dec 9 2019, 5:18 AM.
Tags
None
Referenced Files
F103248058: D22733.diff
Fri, Nov 22, 3:01 PM
Unknown Object (File)
Oct 20 2024, 10:36 AM
Unknown Object (File)
Oct 19 2024, 4:54 PM
Unknown Object (File)
Oct 19 2024, 4:54 PM
Unknown Object (File)
Oct 19 2024, 4:54 PM
Unknown Object (File)
Oct 19 2024, 4:54 PM
Unknown Object (File)
Oct 19 2024, 4:34 PM
Unknown Object (File)
Oct 3 2024, 9:40 AM

Details

Summary

Warn users when they try to add/delete/modify more items than the kernel
will allow.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28074
Build 26219: arc lint + arc unit

Event Timeline

allanjude added a subscriber: allanjude.

Reviewed By: allanjude

This revision is now accepted and ready to land.Dec 9 2019, 6:08 AM

Reporting an "error too many tables" is useful for adding a new table.
It's wrong for deleting and misleading for obtaining statistics.

In D22733#497518, @lutz_donnerhacke.de wrote:

Reporting an "error too many tables" is useful for adding a new table.
It's wrong for deleting and misleading for obtaining statistics.

Good point. I'll see if I can improve the error message.

In D22733#497656, @kp wrote:
In D22733#497518, @lutz_donnerhacke.de wrote:

Reporting an "error too many tables" is useful for adding a new table.
It's wrong for deleting and misleading for obtaining statistics.

Good point. I'll see if I can improve the error message.

I think we need different error messages.
Deleting a table might be stopped by "table in use".
Obtaining statistics might be prevented by "table not found".

If the error message does not reflect the real cause, it will create more harm, than omitting it.

This revision now requires review to proceed.Dec 11 2019, 5:01 AM
This revision is now accepted and ready to land.Dec 11 2019, 8:08 AM
This revision was automatically updated to reflect the committed changes.