Define __SOFT_FP__ for riscv64sf to avoid infinite recursion.
ClosedPublic
Actions

Authored by jhb on Dec 3 2019, 10:32 PM.

Details

Reviewers

br
mhorne
jrtc27
imp

Commits

rS355401: Define __SOFT_FP__ for riscv64sf to avoid infinite recursion.

Test Plan

booted soft-float world built with clang and observed infinite recursion in binaries such as fsck(8)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Dec 3 2019, 10:32 PM

Harbormaster completed remote builds in B27927: Diff 65186.Dec 3 2019, 10:32 PM

jhb added a reviewer: jrtc27.Dec 3 2019, 10:32 PM

Probably this should be on for all soft-float architectures. I'd rather pull in Makefile.float from https://github.com/freebsd/freebsd/commit/eb836f75fe342c01a51bba1c96abacd448fabc88 and use that to set this rather than add all the combinatorics though. This has also only been observed on riscv to date.

In D22660#495654, @jhb wrote:

Probably this should be on for all soft-float architectures. I'd rather pull in Makefile.float from https://github.com/freebsd/freebsd/commit/eb836f75fe342c01a51bba1c96abacd448fabc88 and use that to set this rather than add all the combinatorics though. This has also only been observed on riscv to date.

I think that's a reasonable idea. Since there's an issue now on riscv, I'm cool with this change going in before using that to refine things.

This revision is now accepted and ready to land.Dec 3 2019, 11:38 PM

Closed by commit rS355401: Define __SOFT_FP__ for riscv64sf to avoid infinite recursion. (authored by jhb). · Explain WhyDec 4 2019, 8:18 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS355401: Define __SOFT_FP__ for riscv64sf to avoid infinite recursion..