Use "far" calls and branches so that lld uses valid relocations.
ClosedPublic
Actions

Authored by jhb on Dec 3 2019, 10:27 PM.

Details

Reviewers

br
mhorne
jrtc27

Commits

rS355403: Use "far" calls and branches so that lld uses valid relocations.

Summary

ld.bfd used a R_RISCV_CALL to invoke sigprocmask previously, but this
has the unfortunate effect of sometimes using the PLT stub to permit
symbol resolution and sometimes branching to the local symbol
directly. Far calls and branches use R_RISCV_CALL_PLT which always
uses a PLT stub. lld reports an error when using R_RISCV_CALL in a
shared library, so this fixes the build with lld while also being more
correct.

Test Plan

built world with lld
ran tests from /usr/tests/lib/libc/setjmp

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Dec 3 2019, 10:27 PM

Harbormaster completed remote builds in B27925: Diff 65184.Dec 3 2019, 10:27 PM

jhb added a reviewer: jrtc27.Dec 3 2019, 10:27 PM

jhb added a parent revision: D22656: Use a single 'ld' to read the jmpbuf magic values instead of 'la; ld'..

In this instance it's uses of R_RISCV_JAL/R_RISCV_BRANCH rather than R_RISCV_CALL, but they all behave the same in BFD (plus their compressed variants, and interestingly also R_RISCV_PCREL_HI20). LLD will always error if you use these on undefined/preemptible symbols, much like any other architecture, whereas BFD does the weird resolution as John describes.

br accepted this revision.Dec 4 2019, 2:42 PM

This revision is now accepted and ready to land.Dec 4 2019, 2:42 PM

Closed by commit rS355403: Use "far" calls and branches so that lld uses valid relocations. (authored by jhb). · Explain WhyDec 4 2019, 9:01 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS355403: Use "far" calls and branches so that lld uses valid relocations..

Herald added a subscriber: imp. · View Herald TranscriptDec 4 2019, 9:01 PM