Page MenuHomeFreeBSD

mbuf zones: take out the trash
ClosedPublic

Authored by rlibby on Wed, Nov 27, 7:58 PM.

Details

Summary

The mbuf zones were explicitly specifying the uma trash procedures on
zcreate, conditionally on INVARIANTS, because that used to be necessary
in order to get use-after-free checking for uma zones with non-empty
constructors or destructors. After r355137 uma automatically invokes
the trash constructor and destructor as long as no init and fini are
specified. This now allows the mbuf zones to pass their constructors
and destructors without needing to add on the uma trash procedures
conditionally.

Test Plan

kyua test -k /usr/tests/sys/Kyuafile

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rlibby created this revision.Wed, Nov 27, 7:58 PM
markj accepted this revision.Wed, Nov 27, 8:25 PM

Nice

This revision is now accepted and ready to land.Wed, Nov 27, 8:25 PM
cem accepted this revision.Wed, Nov 27, 9:15 PM
jhb accepted this revision.Mon, Dec 2, 5:42 PM
This revision was automatically updated to reflect the committed changes.