Page MenuHomeFreeBSD

Bhyve AMD IOMMU: log the last timeout command.
ClosedPublic

Authored by anish on Wed, Nov 27, 4:12 AM.

Details

Summary

amdvi_dump_cmds() logs the command for which the command
completion failed. Completion is checked in poll mode although
it can be done using interrupts.

No need to log all the commands in command ring but only the last
one for which completion failed.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anish created this revision.Wed, Nov 27, 4:12 AM
anish updated this revision to Diff 64931.Wed, Nov 27, 4:14 AM
This comment was removed by anish.
anish edited the summary of this revision. (Show Details)Wed, Nov 27, 4:16 AM
markj accepted this revision as: markj.Wed, Nov 27, 4:39 PM
markj added a subscriber: markj.
markj added inline comments.
sys/amd64/vmm/amd/amdvi_hw.c
324 ↗(On Diff #64931)

The parens around AMDVI_CMP_WAIT_STORE are redundant.

This revision is now accepted and ready to land.Wed, Nov 27, 4:39 PM
np accepted this revision.Wed, Nov 27, 6:01 PM
This revision was automatically updated to reflect the committed changes.
anish marked an inline comment as done.