Page MenuHomeFreeBSD
Differential D22566

Bhyve AMD IOMMU: log the last timeout command.
ClosedPublic
Actions

Authored by anish on Nov 27 2019, 4:12 AM.
Tags
None
Referenced Files
F133687230: D22566.id64930.diff
Mon, Oct 27, 2:43 PM
F133653374: D22566.diff
Mon, Oct 27, 7:30 AM
Unknown Object (File)
Sat, Oct 25, 3:37 AM
Unknown Object (File)
Wed, Oct 15, 12:16 AM
Unknown Object (File)
Fri, Oct 10, 11:32 PM
Unknown Object (File)
Fri, Oct 10, 11:32 PM
Unknown Object (File)
Fri, Oct 10, 11:32 PM
Unknown Object (File)
Fri, Oct 10, 11:32 PM
View All Files
Subscribers
bcran
imp
markj
rgrimes

Details

Reviewers
np
markj
Group Reviewers
bhyve
Commits
rS356746: MFC r355258: Bhyve AMD IOMMU log the last timeout command.
rS355258: bhyve amd: amdvi_dump_cmds() log the command for which the command completion…
Summary

amdvi_dump_cmds() logs the command for which the command
completion failed. Completion is checked in poll mode although
it can be done using interrupts.

No need to log all the commands in command ring but only the last
one for which completion failed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

anish created this revision.Nov 27 2019, 4:12 AM
Herald added a reviewer: bhyve. · View Herald TranscriptNov 27 2019, 4:12 AM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
Harbormaster completed remote builds in B27795: Diff 64930.Nov 27 2019, 4:12 AM
anish updated this revision to Diff 64931.Nov 27 2019, 4:14 AM
This comment was removed by anish.
Harbormaster completed remote builds in B27796: Diff 64931.Nov 27 2019, 4:14 AM
anish edited the summary of this revision. (Show Details)Nov 27 2019, 4:16 AM
markj accepted this revision as: markj.Nov 27 2019, 4:39 PM
markj added a subscriber: markj.
markj added inline comments.
sys/amd64/vmm/amd/amdvi_hw.c
324 ↗(On Diff #64931)

The parens around AMDVI_CMP_WAIT_STORE are redundant.

This revision is now accepted and ready to land.Nov 27 2019, 4:39 PM
np accepted this revision.Nov 27 2019, 6:01 PM
Closed by commit rS355258: bhyve amd: amdvi_dump_cmds() log the command for which the command completion… (authored by anish). · Explain WhyDec 1 2019, 4:00 AM
This revision was automatically updated to reflect the committed changes.
anish marked an inline comment as done.
anish added a commit: rS355258: bhyve amd: amdvi_dump_cmds() log the command for which the command completion….
anish added a commit: rS356746: MFC r355258: Bhyve AMD IOMMU log the last timeout command..Jan 15 2020, 2:31 AM

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
vmm/
amd/
16 lines

Diff 65083

View Options

head/sys/amd64/vmm/amd/amdvi_hw.c

Loading...