Page MenuHomeFreeBSD
Differential D22547

schedule new RTT measurement after MTU update
ClosedPublic
Actions

Authored by julius.flohr_uni-due.de on Nov 25 2019, 4:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 12:03 PM
Unknown Object (File)
Feb 10 2024, 5:26 PM
Unknown Object (File)
Dec 15 2023, 8:06 PM
Unknown Object (File)
Dec 11 2023, 4:05 AM
Unknown Object (File)
Dec 2 2023, 6:18 AM
Unknown Object (File)
Nov 21 2023, 3:38 PM
Unknown Object (File)
Nov 14 2023, 6:18 PM
Unknown Object (File)
Oct 9 2023, 12:54 PM
View All 29 Files
Subscribers
imp
melifaro

Details

Reviewers
tuexen
rrs
Group Reviewers
transport
Commits
rS362862: MFC r355265:
rS360751: MFC r355265: Restart RTT measurement
rS355265: When changing the MTU of an SCTP path, not only cancel all ongoing
Summary

After changing the MTU, all outstanding RTT probes are removed from the asoc.sent_queue.
However, no new RTO update is scheduled (net.rto_needed = 1).
This prevents the RTT / RTO from being updated on a regular basis and the net keeps using outdated values.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

julius.flohr_uni-due.de created this revision.Nov 25 2019, 4:32 PM
tuexen accepted this revision.Nov 27 2019, 8:28 PM
This revision is now accepted and ready to land.Nov 27 2019, 8:28 PM
tuexen requested changes to this revision.Nov 27 2019, 8:34 PM
tuexen added inline comments.
sys/netinet/sctp_usrreq.c
171

There is not variable net in head...

This revision now requires changes to proceed.Nov 27 2019, 8:34 PM
tuexen added inline comments.Nov 27 2019, 8:36 PM
sys/netinet/sctp_usrreq.c
171

You might mean chk->whoTo->rto_needed...

julius.flohr_uni-due.de updated this revision to Diff 64981.Nov 27 2019, 10:44 PM
julius.flohr_uni-due.de marked 2 inline comments as done.
julius.flohr_uni-due.de added inline comments.
sys/netinet/sctp_usrreq.c
171

You are of course right. I accidentally diffed against the wrong branch. Sorry.

tuexen accepted this revision.Dec 1 2019, 5:31 PM
tuexen added inline comments.
sys/netinet/sctp_usrreq.c
146

There should be a space between ( and {. Will insert it.

This revision is now accepted and ready to land.Dec 1 2019, 5:31 PM
Closed by commit rS355265: When changing the MTU of an SCTP path, not only cancel all ongoing (authored by tuexen). · Explain WhyDec 1 2019, 5:35 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rS355265: When changing the MTU of an SCTP path, not only cancel all ongoing.
Herald added a subscriber: imp. · View Herald TranscriptDec 1 2019, 5:35 PM
tuexen added a commit: rS360751: MFC r355265: Restart RTT measurement.May 7 2020, 2:35 AM
Herald added a subscriber: melifaro. · View Herald TranscriptMay 7 2020, 2:35 AM
tuexen added a commit: rS362862: MFC r355265:.Jul 1 2020, 8:39 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
5 lines

Diff 64981

View Options

sys/netinet/sctp_usrreq.c

Loading...