Page MenuHomeFreeBSD

schedule new RTT measurement after MTU update
ClosedPublic

Authored by julius.flohr_uni-due.de on Nov 25 2019, 4:32 PM.

Details

Summary

After changing the MTU, all outstanding RTT probes are removed from the asoc.sent_queue.
However, no new RTO update is scheduled (net.rto_needed = 1).
This prevents the RTT / RTO from being updated on a regular basis and the net keeps using outdated values.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Nov 27 2019, 8:28 PM
tuexen requested changes to this revision.Nov 27 2019, 8:34 PM
tuexen added inline comments.
sys/netinet/sctp_usrreq.c
168 ↗(On Diff #64851)

There is not variable net in head...

This revision now requires changes to proceed.Nov 27 2019, 8:34 PM
sys/netinet/sctp_usrreq.c
168 ↗(On Diff #64851)

You might mean chk->whoTo->rto_needed...

julius.flohr_uni-due.de marked 2 inline comments as done.
julius.flohr_uni-due.de added inline comments.
sys/netinet/sctp_usrreq.c
168 ↗(On Diff #64851)

You are of course right. I accidentally diffed against the wrong branch. Sorry.

tuexen added inline comments.
sys/netinet/sctp_usrreq.c
146 ↗(On Diff #64981)

There should be a space between ( and {. Will insert it.

This revision is now accepted and ready to land.Dec 1 2019, 5:31 PM