Page MenuHomeFreeBSD

Enable the RISCV LLVM backend by default.
ClosedPublic

Authored by jhb on Fri, Nov 8, 5:58 PM.

Details

Test Plan
  • able to build riscv64sf world with clang and external binutils
  • tested a world built with WITHOUT_LLVM_TARGET_ALL

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb created this revision.Fri, Nov 8, 5:58 PM
dim accepted this revision.Fri, Nov 8, 6:20 PM

LGTM.

This revision is now accepted and ready to land.Fri, Nov 8, 6:20 PM
emaste added a comment.Fri, Nov 8, 6:20 PM

LGTM

share/mk/src.opts.mk
314 ↗(On Diff #64084)

We should also take riscv out of here at the same time (if it's not moving to the first block right away) - so that independent of the bootstrap compiler question we have a target Clang.

emaste accepted this revision.Fri, Nov 8, 6:20 PM
mhorne accepted this revision.Fri, Nov 8, 9:13 PM

I presume hard-float world can't be built yet due to https://reviews.llvm.org/D66725 still being uncommitted?

jhb added inline comments.Fri, Nov 8, 10:10 PM
share/mk/src.opts.mk
314 ↗(On Diff #64084)

It can't move to the first block due to the hard-float issue, but we could take it out of here, yes.

jhb updated this revision to Diff 64240.Tue, Nov 12, 5:06 PM
  • Enable building of clang by default on riscv.
This revision now requires review to proceed.Tue, Nov 12, 5:06 PM
jhb marked an inline comment as done.Tue, Nov 12, 5:13 PM
emaste accepted this revision.Tue, Nov 12, 5:17 PM
This revision is now accepted and ready to land.Tue, Nov 12, 5:17 PM
dim accepted this revision.Tue, Nov 12, 6:03 PM
This revision was automatically updated to reflect the committed changes.