Page MenuHomeFreeBSD

Cleanup Rockchip clocks implementation.
ClosedPublic

Authored by mmel on Fri, Nov 8, 5:14 PM.

Details

Summary
  • style
  • unify dprinf defines
  • make dprinf's 32-bit compatible

Not a functional change.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mmel created this revision.Fri, Nov 8, 5:14 PM
manu accepted this revision.Fri, Nov 8, 5:43 PM
This revision is now accepted and ready to land.Fri, Nov 8, 5:43 PM
imp added inline comments.Fri, Nov 8, 5:54 PM
sys/arm64/rockchip/clk/rk_clk_armclk.c
77 ↗(On Diff #64079)

maybe have a rockport option for this rather than #if 0

139 ↗(On Diff #64079)

Since j is uintmax_t, do you need a cast here, and points below?

mmel added inline comments.Fri, Nov 8, 6:11 PM
sys/arm64/rockchip/clk/rk_clk_armclk.c
77 ↗(On Diff #64079)

this is for easy enabling of debug printfs for developer , file by file, clock by clock. I don't think that this can be used by 'normal' user.

139 ↗(On Diff #64079)

imo, this is safe area for arm32 long long int and for arm64 long int.
I agree that right way is cast to uintmax_t, but we talking about debug only code and line length is also important. (this mean that i prefer proposed code but i have no strict objection to add uintmax_t cast, even if this breaks code readability a bit..

This revision was automatically updated to reflect the committed changes.