Differential D22281

Cleanup Rockchip clocks implementation.
ClosedPublic
Actions

Authored by mmel on Nov 8 2019, 5:14 PM.

Tags

None

Referenced Files

	F135562367: D22281.id64085.diff
	Mon, Nov 10, 8:27 PM

	Unknown Object (File)
	Sun, Nov 9, 12:32 PM

	Unknown Object (File)
	Sat, Nov 8, 7:59 PM

	Unknown Object (File)
	Sat, Nov 8, 7:49 AM

	Unknown Object (File)
	Thu, Nov 6, 11:35 PM

	Unknown Object (File)
	Sat, Nov 1, 6:04 AM

	Unknown Object (File)
	Mon, Oct 27, 4:27 PM

	Unknown Object (File)
	Sun, Oct 19, 1:53 AM

View All 72 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS358644: MFC r354554-r354558, r355115
rS354555: Cleanup Rockchip clocks implementation.

Summary

style
unify dprinf defines
make dprinf's 32-bit compatible

Not a functional change.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mmel created this revision.Nov 8 2019, 5:14 PM

Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptNov 8 2019, 5:14 PM

manu accepted this revision.Nov 8 2019, 5:43 PM

This revision is now accepted and ready to land.Nov 8 2019, 5:43 PM

imp added inline comments.Nov 8 2019, 5:54 PM

sys/arm64/rockchip/clk/rk_clk_armclk.c
77 ↗	(On Diff #64079)	maybe have a rockport option for this rather than #if 0
139 ↗	(On Diff #64079)	Since j is uintmax_t, do you need a cast here, and points below?

mmel added inline comments.Nov 8 2019, 6:11 PM

sys/arm64/rockchip/clk/rk_clk_armclk.c
77 ↗	(On Diff #64079)	this is for easy enabling of debug printfs for developer , file by file, clock by clock. I don't think that this can be used by 'normal' user.
139 ↗	(On Diff #64079)	imo, this is safe area for arm32 long long int and for arm64 long int. I agree that right way is cast to uintmax_t, but we talking about debug only code and line length is also important. (this mean that i prefer proposed code but i have no strict objection to add uintmax_t cast, even if this breaks code readability a bit..

Closed by commit rS354555: Cleanup Rockchip clocks implementation. (authored by mmel). · Explain WhyNov 8 2019, 7:03 PM

This revision was automatically updated to reflect the committed changes.

mmel added a commit: rS354555: Cleanup Rockchip clocks implementation..

manu added a commit: rS358644: MFC r354554-r354558, r355115.Mar 4 2020, 9:01 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

rockchip/

clk/

rk_clk_armclk.c

21 lines

rk_clk_composite.c

23 lines

2 lines

2 lines

35 lines

9 lines

Diff 64085

head/sys/arm64/rockchip/clk/rk_clk_armclk.c

Loading...

head/sys/arm64/rockchip/clk/rk_clk_composite.c

Loading...

head/sys/arm64/rockchip/clk/rk_clk_gate.c

Loading...

head/sys/arm64/rockchip/clk/rk_clk_mux.c

Loading...

head/sys/arm64/rockchip/clk/rk_clk_pll.c

Loading...

head/sys/arm64/rockchip/clk/rk_cru.c

Loading...