Fix handling of PIPE_EOF in the direct write path.
ClosedPublic
Actions

Authored by markj on Nov 6 2019, 5:11 PM.

Details

Reviewers

Commits

rS354629: Fix handling of PIPE_EOF in the direct write path.

Summary

Suppose a writing thread has pinned its pages and gone to sleep with
pipe_map.cnt > 0. Suppose that the thread is woken up by a signal (so
error != 0) and the other end of the pipe has simultaneously been
closed. In this case, to satisfy the assertion about pipe_map.cnt in
pipe_destroy_write_buffer(), we must mark the buffer as empty.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Nov 6 2019, 5:11 PM

Harbormaster completed remote builds in B27375: Diff 64008.Nov 6 2019, 5:11 PM

markj added a reviewer: kib.Nov 6 2019, 5:12 PM

kib accepted this revision.Nov 6 2019, 8:01 PM

This revision is now accepted and ready to land.Nov 6 2019, 8:01 PM

Peter, could you please test this patch?

In D22261#486883, @markj wrote:

Peter, could you please test this patch?

Sure.

I completed a full stress2 test with D22261.64008.diff.
The only problem I saw was this (unrelated) panic: https://people.freebsd.org/~pho/stress/log/mark107.txt

In D22261#487620, @pho wrote:

I completed a full stress2 test with D22261.64008.diff.
The only problem I saw was this (unrelated) panic: https://people.freebsd.org/~pho/stress/log/mark107.txt

Could you make the vmcore+kernel for this one available?

I only saved the vmcore: https://people.freebsd.org/~pho/vmcore.775.xz

Closed by commit rS354629: Fix handling of PIPE_EOF in the direct write path. (authored by markj). · Explain WhyNov 11 2019, 8:44 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS354629: Fix handling of PIPE_EOF in the direct write path..

Herald added a subscriber: imp. · View Herald TranscriptNov 11 2019, 8:44 PM