Page MenuHomeFreeBSD
Differential D22186

Remove unnecessary object locking from the vnode pager.
ClosedPublic
Actions

Authored by jeff on Oct 30 2019, 2:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 16, 10:51 AM
Unknown Object (File)
Mon, Nov 10, 3:15 AM
Unknown Object (File)
Sun, Nov 9, 12:14 AM
Unknown Object (File)
Sat, Nov 8, 10:04 PM
Unknown Object (File)
Sat, Nov 8, 7:09 AM
Unknown Object (File)
Tue, Nov 4, 12:28 AM
Unknown Object (File)
Fri, Oct 31, 10:20 AM
Unknown Object (File)
Fri, Oct 31, 1:19 AM
View All Files
Subscribers
bdragon
imp

Details

Reviewers
kib
alc
markj
dougm
Commits
rS354870: Remove unnecessary object locking from the vnode pager. Recent changes to
Summary

This is more lock pushdown as a result of the busy/valid/dirty changes.

Test Plan

pho

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jeff created this revision.Oct 30 2019, 2:39 AM
Harbormaster completed remote builds in B27269: Diff 63781.Oct 30 2019, 2:39 AM
jeff edited the summary of this revision. (Show Details)Oct 30 2019, 2:41 AM
jeff edited the test plan for this revision. (Show Details)
jeff added reviewers: kib, alc, markj, dougm.
kib added inline comments.Oct 30 2019, 4:46 PM
sys/vm/vnode_pager.c
1151 ↗(On Diff #63781)

So the consistency of the operation against vnp_size is now depends on the vnode lock, right ? Note that ZFS still calls vnode_pager_setsize() with the vnode unlocked (I fixed this for NFS recently).

jeff added inline comments.Oct 30 2019, 9:25 PM
sys/vm/vnode_pager.c
1151 ↗(On Diff #63781)

You are right. I left read locking around it elsewhere. I can restore that.

bdragon added a subscriber: bdragon.Oct 30 2019, 10:31 PM
jeff updated this revision to Diff 64474.Nov 17 2019, 1:21 AM

Readd a missing lock around the vnode size.

Harbormaster completed remote builds in B27593: Diff 64474.Nov 17 2019, 1:21 AM
markj accepted this revision.Nov 18 2019, 4:15 PM
This revision is now accepted and ready to land.Nov 18 2019, 4:15 PM
kib accepted this revision.Nov 19 2019, 3:15 PM
Closed by commit rS354870: Remove unnecessary object locking from the vnode pager. Recent changes to (authored by jeff). · Explain WhyNov 19 2019, 11:30 PM
This revision was automatically updated to reflect the committed changes.
jeff added a commit: rS354870: Remove unnecessary object locking from the vnode pager. Recent changes to.
Herald added a subscriber: imp. · View Herald TranscriptNov 19 2019, 11:30 PM

Revision Contents
Changeset List

PathSize
head/
sys/
vm/
1 line
2 lines
31 lines

Diff 64595

View Options

head/sys/vm/vm_page.h

Loading...
View Options

head/sys/vm/vm_page.c

Loading...
View Options

head/sys/vm/vnode_pager.c

Loading...