Page MenuHomeFreeBSD

Clear PGA_WRITEABLE in moea_remove_pvo().
ClosedPublic

Authored by markj on Oct 15 2019, 10:08 PM.

Details

Summary

The MOEA pmap clears PGA_WRITEABLE in pmap_remove_{all,write}(), but
fails to do so when a single mapping is removed via pmap_remove().
Correct this.

I couldn't find any other places that were missing this: this pmap does
not implement pmap_remove_pages(), and when a CoW fault removes the last
mapping of a page, its PV entry is removed using moea_remove_pvo().

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj created this revision.Oct 15 2019, 10:08 PM

Tested on G4 in combination with D22041.

bdragon accepted this revision.Oct 16 2019, 1:47 AM
This revision is now accepted and ready to land.Oct 16 2019, 1:47 AM
alc accepted this revision.Oct 16 2019, 2:50 AM
kib accepted this revision.Oct 16 2019, 6:49 AM
This revision was automatically updated to reflect the committed changes.