Page MenuHomeFreeBSD
Differential D21998

RISC-V: Call devmap_print_table() on bootverbose
ClosedPublic
Actions

Authored by nick on Oct 12 2019, 5:35 PM.
Tags
None
Referenced Files
F166195548: D21998.id63193.diff
Wed, Aug 12, 6:52 AM
Unknown Object (File)
Mon, Aug 3, 1:38 AM
Unknown Object (File)
Sun, Aug 2, 6:07 AM
Unknown Object (File)
Sun, Aug 2, 1:01 AM
Unknown Object (File)
Sat, Aug 1, 6:46 AM
Unknown Object (File)
Mon, Jul 27, 5:56 AM
Unknown Object (File)
Sat, Jul 25, 6:38 PM
Unknown Object (File)
Fri, Jul 17, 2:16 PM
View All Files
Subscribers
imp

Details

Reviewers
philip
br
kp
imp
Commits
rS353453: A comment in subr_devmap.c mentions that devmap_print_table() should
Summary

As indicated in the comments for devmap_print_table(), and to maintain
consistency with ARM, call devmap_print_table() on bootverbose.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nick created this revision.Oct 12 2019, 5:35 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 12 2019, 5:35 PM
kp accepted this revision.Oct 12 2019, 5:38 PM

Minor nit: Mention where this is mentioned (i.e. the comments to the function).
Other than that this looks like a good idea to me.

This revision is now accepted and ready to land.Oct 12 2019, 5:38 PM
philip added a comment.Oct 12 2019, 5:41 PM

While you're at it, it would be helpful to fix the dated arm-specific comments in subr_devmap.c. ;-)

nick edited the summary of this revision. (Show Details)Oct 12 2019, 5:50 PM
In D21998#480535, @philip wrote:

While you're at it, it would be helpful to fix the dated arm-specific comments in subr_devmap.c. ;-)

Yeah I'll do that when I get a chance!

imp accepted this revision.Oct 12 2019, 6:11 PM

lgtm.. do you have someone to commit this yet?

philip added a comment.Oct 12 2019, 6:13 PM

I'll take it unless someone beats me to it. :)

Closed by commit rS353453: A comment in subr_devmap.c mentions that devmap_print_table() should (authored by philip). · Explain WhyOct 12 2019, 6:18 PM
This revision was automatically updated to reflect the committed changes.
philip added a commit: rS353453: A comment in subr_devmap.c mentions that devmap_print_table() should.

Revision Contents
Changeset List

PathSize
head/
sys/
riscv/
riscv/
2 lines

Diff 63193

View Options

head/sys/riscv/riscv/machdep.c

Loading...