Page MenuHomeFreeBSD

RISC-V: Call devmap_print_table() on bootverbose
ClosedPublic

Authored by nickisobrien_gmail.com on Oct 12 2019, 5:35 PM.

Details

Summary

As indicated in the comments for devmap_print_table(), and to maintain
consistency with ARM, call devmap_print_table() on bootverbose.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kp accepted this revision.Oct 12 2019, 5:38 PM

Minor nit: Mention where this is mentioned (i.e. the comments to the function).
Other than that this looks like a good idea to me.

This revision is now accepted and ready to land.Oct 12 2019, 5:38 PM

While you're at it, it would be helpful to fix the dated arm-specific comments in subr_devmap.c. ;-)

nickisobrien_gmail.com edited the summary of this revision. (Show Details)Oct 12 2019, 5:50 PM

While you're at it, it would be helpful to fix the dated arm-specific comments in subr_devmap.c. ;-)

Yeah I'll do that when I get a chance!

imp accepted this revision.Oct 12 2019, 6:11 PM

lgtm.. do you have someone to commit this yet?

I'll take it unless someone beats me to it. :)