Differential D21998

RISC-V: Call devmap_print_table() on bootverbose
ClosedPublic
Actions

Authored by nick on Oct 12 2019, 5:35 PM.

Details

Reviewers

philip
br
kp
imp

Commits

rS353453: A comment in subr_devmap.c mentions that devmap_print_table() should

Summary

As indicated in the comments for devmap_print_table(), and to maintain
consistency with ARM, call devmap_print_table() on bootverbose.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nick created this revision.Oct 12 2019, 5:35 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 12 2019, 5:35 PM

Minor nit: Mention where this is mentioned (i.e. the comments to the function).
Other than that this looks like a good idea to me.

This revision is now accepted and ready to land.Oct 12 2019, 5:38 PM

While you're at it, it would be helpful to fix the dated arm-specific comments in subr_devmap.c. ;-)

In D21998#480535, @philip wrote:

While you're at it, it would be helpful to fix the dated arm-specific comments in subr_devmap.c. ;-)

Yeah I'll do that when I get a chance!

lgtm.. do you have someone to commit this yet?

I'll take it unless someone beats me to it. :)

Closed by commit rS353453: A comment in subr_devmap.c mentions that devmap_print_table() should (authored by philip). · Explain WhyOct 12 2019, 6:18 PM

This revision was automatically updated to reflect the committed changes.

philip added a commit: rS353453: A comment in subr_devmap.c mentions that devmap_print_table() should.

Revision Contents
Changeset List

Path

Size

head/

sys/

riscv/

machdep.c

2 lines

Diff 63193

View Options

head/sys/riscv/riscv/machdep.c

RISC-V: Call devmap_print_table() on bootverboseClosedPublicActions