Differential D21911

binutils: Fix bugs found by -Wpointer-compare
ClosedPublic
Actions

Authored by jrtc27 on Oct 6 2019, 1:57 PM.

Tags

None

Referenced Files

	F157151601: D21911.diff
	Mon, May 18, 7:41 PM

	Unknown Object (File)
	Sun, May 17, 4:25 PM

	Unknown Object (File)
	Sun, May 17, 4:21 PM

	Unknown Object (File)
	Sun, May 10, 7:20 AM

	Unknown Object (File)
	Mon, Apr 27, 3:32 PM

	Unknown Object (File)
	Tue, Apr 21, 2:14 AM

	Unknown Object (File)
	Mon, Apr 20, 1:36 AM

	Unknown Object (File)
	Mon, Apr 20, 1:36 AM

View All Files

Subscribers

brooks

imp

Details

Reviewers

emaste
brooks

Commits

rS360318: MFC r354057 (by brooks):
rS354057: binutils: Fix bugs found by -Wpointer-compare

Summary

The MIPS bug was introduced by upstream commit 7403cb630, which failed
to account for the additional indirection introduced and also dropped
one of the checks; change it to the standard "NULL-or-empty" check as
used elsewhere in BFD, which is also what upstream now has.