Page MenuHomeFreeBSD

binutils: Fix bugs found by -Wpointer-compare
ClosedPublic

Authored by jrtc27 on Oct 6 2019, 1:57 PM.

Details

Summary

The MIPS bug was introduced by upstream commit 7403cb630, which failed
to account for the additional indirection introduced and also dropped
one of the checks; change it to the standard "NULL-or-empty" check as
used elsewhere in BFD, which is also what upstream now has.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jrtc27 created this revision.Oct 6 2019, 1:57 PM
brooks accepted this revision.Oct 24 2019, 10:24 PM
brooks added a subscriber: brooks.

LGTM

This revision is now accepted and ready to land.Oct 24 2019, 10:24 PM
This revision was automatically updated to reflect the committed changes.