Differential D21911

binutils: Fix bugs found by -Wpointer-compare
ClosedPublic
Actions

Authored by jrtc27 on Oct 6 2019, 1:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jul 14, 3:05 AM

	Unknown Object (File)
	Thu, Jul 2, 7:51 AM

	Unknown Object (File)
	Tue, Jun 30, 6:02 PM

	Unknown Object (File)
	Mon, Jun 29, 4:49 PM

	Unknown Object (File)
	Mon, Jun 29, 12:58 AM

	Unknown Object (File)
	May 26 2026, 1:04 PM

	Unknown Object (File)
	May 26 2026, 1:01 PM

	Unknown Object (File)
	May 22 2026, 6:36 PM

View All Files

Subscribers

brooks

imp

Details

Reviewers

emaste
brooks

Commits

rS360318: MFC r354057 (by brooks):
rS354057: binutils: Fix bugs found by -Wpointer-compare

Summary

The MIPS bug was introduced by upstream commit 7403cb630, which failed
to account for the additional indirection introduced and also dropped
one of the checks; change it to the standard "NULL-or-empty" check as
used elsewhere in BFD, which is also what upstream now has.