Differential D21911

binutils: Fix bugs found by -Wpointer-compare
ClosedPublic
Actions

Authored by jrtc27 on Oct 6 2019, 1:57 PM.

Tags

None

Referenced Files

	F174780815: D21911.diff
	Mon, Oct 5, 11:08 PM

	Unknown Object (File)
	Mon, Oct 5, 1:49 AM

	Unknown Object (File)
	Tue, Sep 22, 10:53 PM

	Unknown Object (File)
	Mon, Sep 21, 1:23 PM

	Unknown Object (File)
	Mon, Sep 21, 7:47 AM

	Unknown Object (File)
	Mon, Sep 21, 12:01 AM

	Unknown Object (File)
	Sun, Sep 20, 11:58 PM

	Unknown Object (File)
	Sun, Sep 20, 11:46 PM

View All Files

Subscribers

brooks

imp

Details

Reviewers

emaste
brooks

Commits

rS360318: MFC r354057 (by brooks):
rS354057: binutils: Fix bugs found by -Wpointer-compare

Summary

The MIPS bug was introduced by upstream commit 7403cb630, which failed
to account for the additional indirection introduced and also dropped
one of the checks; change it to the standard "NULL-or-empty" check as
used elsewhere in BFD, which is also what upstream now has.