Differential D21911

binutils: Fix bugs found by -Wpointer-compare
ClosedPublic
Actions

Authored by jrtc27 on Oct 6 2019, 1:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Aug 9, 10:27 PM

	Unknown Object (File)
	Sun, Aug 9, 10:27 PM

	Unknown Object (File)
	Sun, Jul 26, 9:59 AM

	Unknown Object (File)
	Fri, Jul 24, 10:37 PM

	Unknown Object (File)
	Tue, Jul 21, 3:17 AM

	Unknown Object (File)
	Tue, Jul 21, 1:33 AM

	Unknown Object (File)
	Jul 14 2026, 3:05 AM

	Unknown Object (File)
	Jul 2 2026, 7:51 AM

View All Files

Subscribers

brooks

imp

Details

Reviewers

emaste
brooks

Commits

rS360318: MFC r354057 (by brooks):
rS354057: binutils: Fix bugs found by -Wpointer-compare

Summary

The MIPS bug was introduced by upstream commit 7403cb630, which failed
to account for the additional indirection introduced and also dropped
one of the checks; change it to the standard "NULL-or-empty" check as
used elsewhere in BFD, which is also what upstream now has.