Differential D21911

binutils: Fix bugs found by -Wpointer-compare
ClosedPublic
Actions

Authored by jrtc27 on Oct 6 2019, 1:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Jan 13 2024, 3:25 AM

	Unknown Object (File)
	Dec 20 2023, 1:12 AM

	Unknown Object (File)
	Aug 11 2023, 11:45 AM

	Unknown Object (File)
	Aug 11 2023, 11:44 AM

	Unknown Object (File)
	Aug 11 2023, 11:43 AM

	Unknown Object (File)
	Aug 9 2023, 6:30 AM

	Unknown Object (File)
	Jun 15 2023, 7:20 PM

	Unknown Object (File)
	Jun 3 2023, 8:04 AM

Subscribers

Details

Reviewers

emaste
brooks

Commits

rS360318: MFC r354057 (by brooks):
rS354057: binutils: Fix bugs found by -Wpointer-compare

Summary

The MIPS bug was introduced by upstream commit 7403cb630, which failed
to account for the additional indirection introduced and also dropped
one of the checks; change it to the standard "NULL-or-empty" check as
used elsewhere in BFD, which is also what upstream now has.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrtc27 created this revision.Oct 6 2019, 1:57 PM

Harbormaster completed remote builds in B26895: Diff 62960.Oct 6 2019, 1:57 PM

LGTM

This revision is now accepted and ready to land.Oct 24 2019, 10:24 PM

Closed by commit rS354057: binutils: Fix bugs found by -Wpointer-compare (authored by brooks). · Explain WhyOct 24 2019, 10:35 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS354057: binutils: Fix bugs found by -Wpointer-compare.

Herald added a subscriber: imp. · View Herald TranscriptOct 24 2019, 10:35 PM

dim added a commit: rS360318: MFC r354057 (by brooks):.Apr 25 2020, 3:51 PM

Revision Contents
Changeset List

Path

Size

head/

contrib/

binutils/

bfd/

2 lines

binutils/

2 lines

Diff 63656

head/contrib/binutils/bfd/elfxx-mips.c

Loading...

head/contrib/binutils/binutils/stabs.c

Loading...