Page MenuHomeFreeBSD

Disallow fcntl(F_READAHEAD) when the vnode is not a regular file.
ClosedPublic

Authored by markj on Oct 1 2019, 8:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 24, 8:31 AM
Unknown Object (File)
Wed, Sep 23, 2:33 AM
Unknown Object (File)
Wed, Sep 23, 2:33 AM
Unknown Object (File)
Wed, Sep 23, 2:32 AM
Unknown Object (File)
Wed, Sep 23, 2:29 AM
Unknown Object (File)
Tue, Sep 15, 10:13 AM
Unknown Object (File)
Tue, Sep 15, 3:17 AM
Unknown Object (File)
Wed, Sep 9, 6:09 PM
Subscribers

Details

Summary

f_iosize is 0 for devfs vnodes, resulting in a divide by zero if one
calls, for example, fcntl(STDIN_FILENO, F_READAHEAD, 4096).

The sequential heuristic is not applied to I/O to or from device files,
and posix_fadvise(2) returns an error for v_type != VREG, so do the same
here too.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable