Page MenuHomeFreeBSD

Style cleanup in elf_machdep.c
ClosedPublic

Authored by mhorne on Sep 24 2019, 12:54 AM.
Tags
None
Referenced Files
F168387047: D21772.diff
Thu, Aug 27, 10:39 PM
Unknown Object (File)
Thu, Aug 27, 10:49 AM
Unknown Object (File)
Wed, Aug 26, 7:47 PM
Unknown Object (File)
Wed, Aug 26, 12:47 PM
Unknown Object (File)
Wed, Aug 26, 11:13 AM
Unknown Object (File)
Wed, Aug 26, 10:28 AM
Unknown Object (File)
Tue, Aug 25, 2:09 AM
Unknown Object (File)
Mon, Aug 24, 6:27 PM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Remove an extra set of redundant parenthesis.

sys/riscv/riscv/elf_machdep.c
116 ↗(On Diff #62491)

Note that changing sysctl types is technically not a style change since userland code which reads the value using an int will be broken. We've had regressions in the past when a similar change was merged to a stable branch. I think it's fine in this case: we don't currently aim to preserve binary compatibility for RISC-V and I doubt that there is any C code that toggles this sysctl.

Since you're changing the type, could you also move the sysctl under the debug OID? Maybe debug.kld_reloc or so.

319 ↗(On Diff #62491)

I'd also get rid of the blank lines around this assignment.

416 ↗(On Diff #62491)

The indentation is still wrong here.

Address markj's comments.
Remove some additional blank lines.

This revision is now accepted and ready to land.Sep 25 2019, 12:09 AM
This revision was automatically updated to reflect the committed changes.