Paths

Table of Contentst

Differential D21741

Go ports: cleanup, finish transition to USES=go started with r505321 (cat. audio-mail)
ClosedPublic
Actions

Authored by dmgk on Sep 21 2019, 7:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 4, 6:44 PM

	Unknown Object (File)
	Fri, Sep 27, 6:52 AM

	Unknown Object (File)
	Sun, Sep 22, 11:05 PM

	Unknown Object (File)
	Sat, Sep 21, 4:25 AM

	Unknown Object (File)
	Fri, Sep 20, 1:21 PM

	Unknown Object (File)
	Sun, Sep 15, 3:09 AM

	Unknown Object (File)
	Sat, Sep 14, 7:42 PM

	Unknown Object (File)
	Thu, Sep 12, 9:12 PM

View All 99 Files

Subscribers

Details

Reviewers

tz
araujo
swills
tobik

Group Reviewers

Commits

rP513274: Go ports: cleanup, finish transition to USES=go started with r505321 (cat.

Summary

Go ports: cleanup, finish transition to USES=go started with r505321 (cat. audio-mail)

Remove custom build/install targets left in place after r505321
Switch to the new GO_TARGET tuple syntax introduced in r512001
Switch to go:modules when upstream already uses them

Test Plan

poudriere bulk -C: OK (113i, 120a)
exp-run

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 26605
Build 24984: arc lint + arc unit

Event Timeline

dmgk created this revision.Sep 21 2019, 7:20 PM

Herald added a subscriber: mat. · View Herald TranscriptSep 21 2019, 7:20 PM

Harbormaster completed remote builds in B26605: Diff 62399.Sep 21 2019, 7:20 PM

tobik added inline comments.Sep 23 2019, 4:39 AM

audio/pms-devel/Makefile
21	Many dependencies have changed here (some tags do not match the commits from before). Why? Make sure to bump PORTREVISION to force a rebuild for this.

dmgk marked an inline comment as done.Sep 23 2019, 12:25 PM

dmgk added inline comments.

audio/pms-devel/Makefile
21	Hmm.. I'm not sure where original dependencies came from, upstream doesn't seem to have used anything except modules. The new GH_TUPLE was generated by gomod-vendor target. But this definitely needs a PORTREVISION bump, thanks for spotting.

Bump audio/pms-devel PORTREVISION for dependencies change.

Harbormaster completed remote builds in B26645: Diff 62460.Sep 23 2019, 12:26 PM

dmgk edited the test plan for this revision. (Show Details)Sep 23 2019, 12:27 PM

tobik requested changes to this revision.Sep 23 2019, 3:42 PM

tobik added inline comments.

editors/micro/Makefile
46	Typo here. Should be `GO_BUIILDFLAGS`.

This revision now requires changes to proceed.Sep 23 2019, 3:42 PM

Fix GO_BUIILDFLAGS typo in editors/micro/Makefile

Harbormaster completed remote builds in B26652: Diff 62472.Sep 23 2019, 3:48 PM

dmgk marked an inline comment as done.Sep 23 2019, 3:48 PM

tobik accepted this revision.Sep 23 2019, 4:00 PM

This revision is now accepted and ready to land.Sep 23 2019, 4:00 PM

It looks good to me, but you need to wait for the exp-run and also portmgr approval.
Thanks to work on this.

dmgk mentioned this in D21744: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. sysutils-x11).Sep 29 2019, 7:25 PM

Closed by commit rP513274: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. (authored by dmgk). · Explain WhySep 29 2019, 10:30 PM

This revision was automatically updated to reflect the committed changes.

dmgk added a commit: rP513274: Go ports: cleanup, finish transition to USES=go started with r505321 (cat..

Revision Contents
Changeset List

Path

Size

audio/

pms-devel/

74 lines

104 lines

benchmarks/

vegeta/

44 lines

databases/

go-carbon/

10 lines

influxdb/

206 lines

mongodb40-tools/

28 lines

deskutils/

chart/

21 lines

noti/

8 lines

pet/

1 line

devel/

arduino-builder/

18 lines

arduinoOTA/

8 lines

bazel-buildtools/

9 lines

etcd/

4 lines

etcd31/

16 lines

etcd32/

16 lines

etcd33/

16 lines

files/

patch-.._src_github.com_coreos_go-systemd_util_util__cgo.go

	patch-cmd_vendor_github.com_coreos_go-systemd_util_util__cgo.go
	patch-.._src_github.com_coreos_go-systemd_util_util__cgo.go

4 lines

git-codereview/

16 lines

git-lfs/

2 lines

git-town/

6 lines

gitlab-runner/

21 lines

gitlab-shell/

2 lines

go-bindata/

15 lines

go-git/

14 lines

go-protobuf/

29 lines

go-tools/

29 lines

goprotobuf/

8 lines

jfrog-cli/

2 lines

jiri/

20 lines

lazygit/

8 lines

loccount/

9 lines

mage/

7 lines

pprof/

11 lines

dns/

cli53/

11 lines

dnscrypt-proxy2/

14 lines

editors/

micro/

63 lines

finance/

fixc/

7 lines

mail/

mailhog/

50 lines

Diff 62399

audio/pms-devel/Makefile

Loading...

audio/pms-devel/distinfo

Loading...

benchmarks/vegeta/Makefile

Loading...

databases/go-carbon/Makefile

Loading...

databases/influxdb/Makefile

Loading...

databases/mongodb40-tools/Makefile

Loading...

deskutils/chart/Makefile

Loading...

deskutils/noti/Makefile

Loading...

deskutils/pet/Makefile

Loading...

devel/arduino-builder/Makefile

Loading...

devel/arduinoOTA/Makefile

Loading...

devel/bazel-buildtools/Makefile

Loading...

devel/etcd/Makefile

Loading...

devel/etcd31/Makefile

Loading...

devel/etcd32/Makefile

Loading...

devel/etcd33/Makefile

Loading...

devel/etcd33/files/patch-.._src_github.com_coreos_go-systemd_util_util__cgo.go

Loading...

devel/etcd33/files/patch-cmd_vendor_github.com_coreos_go-systemd_util_util__cgo.go

Loading...

devel/git-codereview/Makefile

Loading...

devel/git-lfs/Makefile

Loading...

devel/git-town/Makefile

Loading...

devel/gitlab-runner/Makefile

Loading...

devel/gitlab-shell/Makefile

Loading...

devel/go-bindata/Makefile

Loading...

devel/go-git/Makefile

Loading...

devel/go-protobuf/Makefile

Loading...

devel/go-tools/Makefile

Loading...

devel/goprotobuf/Makefile

Loading...

devel/jfrog-cli/Makefile

Loading...

devel/jiri/Makefile

Loading...

devel/lazygit/Makefile

Loading...

devel/loccount/Makefile

Loading...

devel/mage/Makefile

Loading...

devel/pprof/Makefile

Loading...

dns/cli53/Makefile

Loading...

dns/dnscrypt-proxy2/Makefile

Loading...

editors/micro/Makefile

Loading...

finance/fixc/Makefile

Loading...

mail/mailhog/Makefile

Loading...