Page MenuHomeFreeBSD

makesyscalls.sh: generate boilerplate for standard COMPAT* options
AbandonedPublic

Authored by kevans on Sep 19 2019, 3:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 5 2024, 10:03 AM
Unknown Object (File)
Sep 4 2024, 6:39 AM
Unknown Object (File)
Sep 1 2024, 3:23 AM
Unknown Object (File)
Aug 24 2024, 3:35 AM
Unknown Object (File)
Aug 13 2024, 5:51 AM
Unknown Object (File)
Aug 6 2024, 7:48 AM
Unknown Object (File)
Jul 23 2024, 1:38 AM
Unknown Object (File)
Jun 10 2024, 12:01 PM
Subscribers
None

Details

Summary

My awk chops aren't great -- how about this approach?

Leave COMPAT_43 out as it's the odd man out, as far as naming convention goes. Group all of the compat options thereafter in a stdcompat variable, then generate the awk we use for each section.

This has the disadvantage of having to go back to the top when you're trying to grok the script, but I'm not convinced this is highly important given the rate of change.

Test Plan
  • Ran make sysent, no diff
  • Added FREEBSD12, results look OK

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 26572

Event Timeline

This is rather clever, but I don't like this direction. I'd like to remove the embedding of awk in sh that currently exists and this makes it much harder.

I'm also having difficulty getting an internal change to work in this model (I'm sure it's possible, but i've spend 30 minutes so far without luck) that allows sys/compat layers to list the minimum COMPAT version they support which allows me to avoid implementing FreeBSD 4 compat in CheriABI and our compat/freebsd64 layer.

This is rather clever, but I don't like this direction. I'd like to remove the embedding of awk in sh that currently exists and this makes it much harder.

I'm also having difficulty getting an internal change to work in this model (I'm sure it's possible, but i've spend 30 minutes so far without luck) that allows sys/compat layers to list the minimum COMPAT version they support which allows me to avoid implementing FreeBSD 4 compat in CheriABI and our compat/freebsd64 layer.

Back to the drawing board. =)

Which direction are you thinking of heading in- pure awk, or stepping away from awk to... something else?

Your mincompat stuff would look something like this in this model: https://people.freebsd.org/~kevans/mincompat.diff

Let's make lua a build-tool :)