Fix compiler_rt definition for RISC-V
ClosedPublic
Actions

Authored by luis_luismarques.eu on Sep 17 2019, 10:30 AM.

Details

Reviewers

emaste
andrew
br

Commits

rS352792: compiler-rt: correct RISC-V struct_kernel_stat64_sz

Summary

The value of struct_kernel_stat64_sz introduced by D5021 for RISC-V is incorrect. This patch fixes that issue.
The use of the __riscv_xlen == 64 condition is due to the fact that the 32-bit Linux ABI is not yet finalized.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

luis_luismarques.eu created this revision.Sep 17 2019, 10:30 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 17 2019, 10:30 AM

emaste added a reviewer: br.Sep 27 2019, 1:04 PM

emaste accepted this revision.Sep 27 2019, 1:07 PM

This revision is now accepted and ready to land.Sep 27 2019, 1:07 PM

Thanks!

We need to figure out how to get all of this upstream as well.

Closed by commit rS352792: compiler-rt: correct RISC-V struct_kernel_stat64_sz (authored by emaste). · Explain WhySep 27 2019, 1:14 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS352792: compiler-rt: correct RISC-V struct_kernel_stat64_sz.

In D21684#476228, @emaste wrote:

We need to figure out how to get all of this upstream as well.

There is an upstream patch ready to land that covers these changes, plus a bit more: https://reviews.llvm.org/D66870

dim mentioned this in rS356460: Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp.Jan 7 2020, 6:13 PM

dim mentioned this in rS360658: Merge llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and openmp.May 5 2020, 1:05 PM

Revision Contents
Changeset List

Path

Size

lib/

sanitizer_common/

sanitizer_platform_limits_posix.h

5 lines

Diff 62205

View Options

lib/sanitizer_common/sanitizer_platform_limits_posix.h

Fix compiler_rt definition for RISC-VClosedPublicActions