linux_renameat2: improve flag checks
ClosedPublic
Actions

Authored by emaste on Sep 11 2019, 1:21 PM.

Tags

None

Referenced Files

	F114606604: D21606.diff
	Mon, Apr 14, 9:02 AM

	F114583399: D21606.id.diff
	Mon, Apr 14, 4:19 AM

	F114558540: D21606.id64040.diff
	Sun, Apr 13, 11:33 PM

	Unknown Object (File)
	Sun, Apr 13, 9:32 PM

	Unknown Object (File)
	Sun, Apr 6, 11:42 AM

	Unknown Object (File)
	Mon, Mar 17, 6:30 PM

	Unknown Object (File)
	Feb 28 2025, 4:28 PM

	Unknown Object (File)
	Feb 25 2025, 6:16 AM

View All 49 Files

Subscribers

imp

mjg

Details

Reviewers

trasz
kaktus

Group Reviewers

Linux Emulation

Commits

rG4d0dc71a7bf0: linux_renameat2: improve flag checks
rS354447: linux_renameat2: improve flag checks

Summary

In the cases where Linux returns an error (e.g. passing in an undefined flag) there's no need for us to emit a message.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

https://manpages.debian.org/testing/manpages-dev/renameat2.2.en.html

This adds these cases:

EINVAL
    An invalid flag was specified in flags.
EINVAL
    Both RENAME_NOREPLACE and RENAME_EXCHANGE were specified in flags.
EINVAL
    Both RENAME_WHITEOUT and RENAME_EXCHANGE were specified in flags.

emaste added a reviewer: kaktus.Sep 30 2019, 4:04 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 7 2019, 3:51 PM

Closed by commit rS354447: linux_renameat2: improve flag checks (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS354447: linux_renameat2: improve flag checks.

Herald added a subscriber: imp. · View Herald TranscriptNov 7 2019, 3:51 PM

dchagin added a commit: rG4d0dc71a7bf0: linux_renameat2: improve flag checks.Jun 10 2021, 9:32 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

compat/

linux/

linux_file.h

7 lines

linux_file.c

7 lines

Diff 64040

View Options

head/sys/compat/linux/linux_file.h