Page MenuHomeFreeBSD

avoid unneeded call to arc4random() in syncache_add()
ClosedPublic

Authored by gallatin on Sep 10 2019, 7:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 22, 2:20 PM
Unknown Object (File)
Sat, Aug 22, 11:57 AM
Unknown Object (File)
Fri, Aug 21, 2:57 PM
Unknown Object (File)
Fri, Aug 21, 2:45 PM
Unknown Object (File)
Fri, Aug 21, 12:47 PM
Unknown Object (File)
Thu, Aug 20, 9:09 PM
Unknown Object (File)
Wed, Aug 12, 1:47 PM
Unknown Object (File)
Mon, Aug 10, 9:16 AM
Subscribers

Details

Summary

We currently call arc4random() unconditionally to initialize sc_iss, but then when syncookies are enabled, we overwrite it with the return value from from syncookie_generate(). It would seem to make more sense to only call arc4random() when syncookies are not enabled.

Note that on a system under a syn flood attack, arc4random() becomes quite expensive, and the chacha_poly crypto that it calls is one of the more expensive things happening on the system. Removing this unneeded arc4random() call reduces CPU from about 40% to about 35% in my test scenario (Broadwell Xeon, 6Mpps syn flood attack).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable