Make pseudofs(9) create directory entries in order
ClosedPublic
Actions

Authored by trasz on Sep 6 2019, 1:07 PM.

Details

Reviewers

des
kib

Commits

rS352334: Make pseudofs(9) create directory entries in order, instead

Summary

Make pseudofs(9) create directory entries in order, instead
of the reverse.

This fixes Linux sysctl(8) binary - it assumes the first two
directory entries are always "." and "..". There might be other
Linux apps affected by this.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Sep 6 2019, 1:07 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 6 2019, 1:07 PM

Harbormaster completed remote builds in B26309: Diff 61728.Sep 6 2019, 1:07 PM

trasz added reviewers: des, kib.Sep 6 2019, 1:08 PM

kib added inline comments.Sep 6 2019, 2:00 PM

sys/fs/pseudofs/pseudofs.c
145 ↗	(On Diff #61728)	I think you do not need this check, instead fold it with the previous pn_nodes == NULL branch. KASSERT() there demonstrates it nicely.
172 ↗	(On Diff #61728)	What if pn_next never equal to pn ?

Fixes from kib.

Harbormaster completed remote builds in B26351: Diff 61832.Sep 9 2019, 11:32 AM

Thanks; does the updated version look ok?

Did you considered switching to sys/queue.h ?

This revision is now accepted and ready to land.Sep 9 2019, 12:41 PM

I've thought about it; I guess des@ hadn't used that to avoid contaminating pseudofs headers with queue.h, and I didn't want to change it.

In D21550#470047, @trasz wrote:

I've thought about it; I guess des@ hadn't used that to avoid contaminating pseudofs headers with queue.h, and I didn't want to change it.

Lets take a look. Very first line of pseudofs.h includes sys/jail.h. In sys/jail.h line 121 we see inclusion of sys/queue.h.

Closed by commit rS352334: Make pseudofs(9) create directory entries in order, instead (authored by trasz). · Explain WhySep 14 2019, 7:16 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS352334: Make pseudofs(9) create directory entries in order, instead.