Make pseudofs(9) create directory entries in order

[trasz]

Summary

Make pseudofs(9) create directory entries in order, instead
of the reverse.

This fixes Linux sysctl(8) binary - it assumes the first two
directory entries are always "." and "..". There might be other
Linux apps affected by this.

[kib]

sys/fs/pseudofs/pseudofs.c

145

I think you do not need this check, instead fold it with the previous pn_nodes == NULL branch. KASSERT() there demonstrates it nicely.

172

What if pn_next never equal to pn ?

[trasz]

Fixes from kib.

[trasz]

Thanks; does the updated version look ok?

[kib]

Did you considered switching to sys/queue.h ?

[trasz]

I've thought about it; I guess des@ hadn't used that to avoid contaminating pseudofs headers with queue.h, and I didn't want to change it.

[kib]

In D21550#470047, @trasz wrote:

I've thought about it; I guess des@ hadn't used that to avoid contaminating pseudofs headers with queue.h, and I didn't want to change it.

Lets take a look. Very first line of pseudofs.h includes sys/jail.h. In sys/jail.h line 121 we see inclusion of sys/queue.h.