Fix usage of angle-brackets and quotes in make(1) manpage
ClosedPublic
Actions

Authored by andrew_tao173.riddles.org.uk on Aug 29 2019, 8:37 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mar 20 2024, 10:22 AM

	Unknown Object (File)
	Mar 17 2024, 6:21 PM

	Unknown Object (File)
	Dec 20 2023, 4:30 AM

	Unknown Object (File)
	Nov 9 2023, 10:22 AM

	Unknown Object (File)
	Oct 31 2023, 10:20 PM

	Unknown Object (File)
	Oct 31 2023, 12:19 AM

	Unknown Object (File)
	Oct 28 2023, 4:41 PM

	Unknown Object (File)
	Oct 8 2023, 9:20 AM

Subscribers

Contributor Reviews (src)

Details

Reviewers

bcr
0mp

Group Reviewers

manpages

Summary

make(1) has commands .include <file> and .include "file", but the manpage was (inconsistently) rendering <file> with angle-brackets (e.g. in UTF8 output, ⟨file⟩ ) and "file" with curly-quotes in HTML output (but not text).

This is an attempt to fix that and output only literal <file> and "file" as is actually required in the makefile.

Test Plan

none

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

andrew_tao173.riddles.org.uk created this revision.Aug 29 2019, 8:37 PM

Herald added a reviewer: manpages. · View Herald TranscriptAug 29 2019, 8:37 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript

Thanks for the patch! I've tested the HTML output and it looks much better now.

Can I commit it, @bcr?

This revision is now accepted and ready to land.Feb 3 2020, 10:39 AM

This is in /contrib, so is bmake coming from another project or are we maintaining bmake these days? When the former is true, it would be good to send the patch upstream, so that we can get it from there without having to maintain it locally.